Skip to content

Commit cbcb49c

Browse files
authored
fix: allow null value for number and date (#1472)
1 parent f332c3b commit cbcb49c

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

front/src/modules/ui/editable-field/types/FieldMetadata.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export type FieldMetadata =
100100
export type FieldTextValue = string;
101101

102102
export type FieldChipValue = string;
103-
export type FieldDateValue = string;
103+
export type FieldDateValue = string | null;
104104
export type FieldPhoneValue = string;
105105
export type FieldURLValue = string;
106106
export type FieldNumberValue = number | null;

front/src/modules/ui/editable-field/types/guards/isFieldDateValue.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ export function isFieldDateValue(
55
fieldValue: unknown,
66
): fieldValue is FieldDateValue {
77
return (
8-
fieldValue !== null &&
9-
fieldValue !== undefined &&
10-
typeof fieldValue === 'string'
8+
fieldValue === null ||
9+
(fieldValue !== undefined && typeof fieldValue === 'string')
1110
);
1211
}

front/src/modules/ui/editable-field/types/guards/isFieldNumberValue.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ export function isFieldNumberValue(
55
fieldValue: unknown,
66
): fieldValue is FieldNumberValue {
77
return (
8-
fieldValue !== null &&
9-
fieldValue !== undefined &&
10-
typeof fieldValue === 'number'
8+
fieldValue === null ||
9+
(fieldValue !== undefined && typeof fieldValue === 'number')
1110
);
1211
}

0 commit comments

Comments
 (0)