ensure tests will pass if no mcp dependencies are installed, install the dependencies in ci so the tests will run there

Author: bcallender

src/fenic/api/mcp/_tool_generation_utils.py

@@ -8,25 +8,24 @@
 import polars as pl
 from typing_extensions import Annotated
 
-from fenic import (
+from fenic.api import col
+from fenic.api.dataframe import DataFrame
+from fenic.api.functions import avg, stddev
+from fenic.api.functions import max as max_
+from fenic.api.functions import min as min_
+from fenic.api.session import Session
+from fenic.core._logical_plan import LogicalPlan
+from fenic.core._logical_plan.plans import InMemorySource
+from fenic.core._utils.schema import convert_custom_dtype_to_polars
+from fenic.core.error import ConfigurationError, ValidationError
+from fenic.core.mcp.types import SystemTool
+from fenic.core.types.datatypes import (
     BooleanType,
-    DataFrame,
     DoubleType,
     FloatType,
     IntegerType,
-    Session,
     StringType,
-    SystemTool,
-    avg,
-    col,
-    stddev,
 )
-from fenic import max as max_
-from fenic import min as min_
-from fenic.core._logical_plan import LogicalPlan
-from fenic.core._logical_plan.plans import InMemorySource
-from fenic.core._utils.schema import convert_custom_dtype_to_polars
-from fenic.core.error import ConfigurationError, ValidationError
 
 PROFILE_MAX_SAMPLE_SIZE = 10_000
 

src/fenic/core/_serde/proto/serde_context.py

@@ -58,8 +58,8 @@
 from fenic.core.mcp._validators import get_param_validator
 from fenic.core.mcp.types import (
     BoundToolParam,
-    UserDefinedTool,
     ToolParamConstraints,
+    UserDefinedTool,
 )
 from fenic.core.types.datatypes import DataType
 from fenic.core.types.schema import ColumnField, Schema

src/fenic/core/mcp/_server.py

@@ -36,8 +36,8 @@
 from fenic.core.mcp.types import (
     SystemTool,
     TableFormat,
-    UserDefinedTool,
     ToolParamConstraints,
+    UserDefinedTool,
 )
 from fenic.core.types.datatypes import ArrayType
 from fenic.logging import configure_logging

src/fenic/core/mcp/types.py

@@ -87,10 +87,10 @@ class BoundToolParam:
     data_type: DataType
     required: bool
     has_default: bool
-    default_value: Optional[ToolParameterType]
-    allowed_values: Optional[List[ToolParameterType]]
-    constraints: Optional[ToolParamConstraints]
-    validators: List[ParamValidator]
+    default_value: Optional[ToolParameterType] = None
+    allowed_values: Optional[List[ToolParameterType]] = None
+    constraints: Optional[ToolParamConstraints] = None
+    validators: List[ParamValidator] = Field(default_factory=list)
 
 
 @dataclass(config=ConfigDict(arbitrary_types_allowed=True))

tests/api/mcp/test_server.py

@@ -3,6 +3,9 @@
 import pytest
 
 from fenic import ToolGenerationConfig
+
+pytest.importorskip("fastmcp")
+
 from fenic.api.functions import col, tool_param
 from fenic.api.mcp.server import create_mcp_server
 from fenic.api.mcp.tools import auto_generate_system_tools_from_tables
@@ -15,7 +18,6 @@
 
 
 def test_server_generation_with_parameterized_tools(local_session: Session):
-    pytest.importorskip("fastmcp")
     df = local_session.create_dataframe({"city": ["SF"], "age": [10], "user_name": ["Alice"]})
     query = df.filter(
         (col("city") == tool_param("city_name", StringType))
@@ -35,7 +37,7 @@ def test_server_generation_with_parameterized_tools(local_session: Session):
         query=query,
     )
 
-    server = create_mcp_server(local_session, "Test Server", parameterized_tools=[parameterized_tool])
+    server = create_mcp_server(local_session, "Test Server", user_defined_tools=[parameterized_tool])
     server_tools = asyncio.run(server.mcp.get_tools())
     assert len(server_tools) == 1
     parameter_schema = server_tools["tool_x"].parameters['properties']
@@ -57,7 +59,6 @@ def test_server_generation_with_parameterized_tools(local_session: Session):
     assert user_names_param['description'] == "User names"
 
 def test_server_generation(local_session: Session):
-    pytest.importorskip("fastmcp")
     create_table_with_rows(local_session, "t1", [1, 2, 3], description="table one")
     create_table_with_rows(local_session, "t2", [10, 20], description="table two")
     tools = auto_generate_system_tools_from_tables(["t1", "t2"], local_session, tool_group_name="Auto")

tests/core/mcp/test_binder.py

@@ -80,7 +80,6 @@ def test_bind_parameters_type_mismatch_raises(local_session: Session):
                     required=True,
                     has_default=False,
                     allowed_values=None,
-                    default_value=None,
                 )
             ],
         )