Skip to content

fix: make catalog use sc method to implement does_table_exist #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
german-typedef merged 1 commit into from
Jul 18, 2025
Merged

fix: make catalog use sc method to implement does_table_exist #90

german-typedef merged 1 commit into from
Jul 18, 2025

Conversation

@german-typedef
Copy link
Contributor

@german-typedef german-typedef commented Jul 17, 2025 •
edited
Loading

TL;DR

Use a simple catalog way to determine if a table is available.

What changed?

  • Modified CloudCatalog initialization to accept direct parameters instead of depending on CloudSessionState
  • Added a new _get_table method to improve table existence checking
  • Updated _does_table_exist to use the new method instead of fetching all tables
  • Updated tests to accommodate the new structure

@german-typedef Graphite App
Copy link
Contributor Author

german-typedef commented Jul 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@german-typedef german-typedef marked this pull request as ready for review July 17, 2025 20:43
This was referenced Jul 17, 2025
Open
Open
bcallender
bcallender approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@bcallender bcallender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple of nits

@german-typedef german-typedef force-pushed the 07-17-fix_make_catalog_use_sc_method_to_implement_does_table_exist branch from 5906010 to f984214 Compare July 18, 2025 17:46
@german-typedef german-typedef force-pushed the 07-17-fix_make_catalog_use_sc_method_to_implement_does_table_exist branch from f984214 to c2218e9 Compare July 18, 2025 17:55
@german-typedef Graphite App
Copy link
Contributor Author

german-typedef commented Jul 18, 2025 •
edited
Loading

Merge activity

  • Jul 18, 5:56 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 18, 5:57 PM UTC: @german-typedef merged this pull request with Graphite.

@german-typedef german-typedef merged commit 513da9a into main Jul 18, 2025
12 checks passed
@german-typedef german-typedef deleted the 07-17-fix_make_catalog_use_sc_method_to_implement_does_table_exist branch July 18, 2025 17:57
@typedef-ai-gha typedef-ai-gha bot mentioned this pull request Jul 18, 2025
Merged
rohitrastogi pushed a commit that referenced this pull request Aug 4, 2025
@typedef-ai-gha
chore(main): release 0.3.0 (#61)
2501708 
🤖 I have created a release *beep* *boop*
---


## [0.3.0](v0.2.1...v0.3.0)
(2025-08-04)


### Features

* Add basic support for WebVTT format to transcript parser
([97162af](97162af)),
closes [#71](#71)
* Add full support for complex Pydantic models in `semantic.extract`;
deprecate custom `ExtractSchema`
([#66](#66))
([b69baff](b69baff))
* add implementation for text.jinja() column function
([#98](#98))
([b784181](b784181))
* add jinja expr and validate jinja template against input exprs
([#96](#96))
([4e71293](4e71293))
* Add jinja template validation and variable extraction to be used in
jinja rendering column function and more
([#87](#87))
([fdd87e5](fdd87e5))
* add Jinja templating support to semantic operations
([9bcccff](9bcccff))
* add pretty printed string representation for schema
([616f541](616f541))
* add rust utility to convert arrow array values into minijinja contexts
([#97](#97))
([9901253](9901253))
* add support for basic fuzzy string ratio column functions
([791e662](791e662))
* Add support for Cohere embeddings
([#116](#116))
([bf004df](bf004df))
* add support for greatest/least column functions
([0aa0636](0aa0636))
* Add support for webvtt transcript format
([#105](#105))
([97162af](97162af))
* convert json/markdown functions to ScalarFunction
([#55](#55))
([1d5be25](1d5be25))
* convert semantic/embedding exprs to ScalarFunction
([#56](#56))
([ea7f6ca](ea7f6ca))
* function registry for signature validation
([#53](#53))
([a33747f](a33747f))
* Implemented embeddings client for gemini with preset support for
variable output dimensionality
([#111](#111))
([2104bfe](2104bfe))
* make SemanticConfig optional to support OLAP-only and partial semantic
operations ([#100](#100))
([5f8e3cb](5f8e3cb))
* register/convert text functions using ScalarFunction
([#54](#54))
([15a8c26](15a8c26))
* replace pylance kmeans implementation with scikit-learn and expose
num_init and max_iter params in api
([#104](#104))
([fdea6af](fdea6af))
* semantic map can now generate content with pydantic schema
([#78](#78))
([0148c81](0148c81))
* summarization function
([#37](#37))
([2e83645](2e83645))
* support descriptions of class labels in semantic.classify
([baf3897](baf3897))
* support dynamic array index via expr arg in column.get_item()
([7795497](7795497))
* Support for persistent views
([#41](#41))
([63747c0](63747c0))
* support model profiles with different thinking/reasoning
configurations ([#82](#82))
([4a05c1a](4a05c1a))
* use composition instead of inheritance for signature validation
([#63](#63))
([1b8983e](1b8983e))


### Bug Fixes

* embedding profile assumptions
([#125](#125))
([131db13](131db13))
* ensure total_output_tokens is populated even if the api response does
not include it ([#62](#62))
([496c5fd](496c5fd))
* fix broken typesignature/functionsignature imports
([#84](#84))
([2a3460b](2a3460b))
* fix bugs in text.extract related to delimiter sequence parsing and
also disallow empty column names in templates
([#75](#75))
([fb96b13](fb96b13))
* grpc should use fenic's asyncio event loop
([#85](#85))
([356086a](356086a))
* make catalog use sc method to implement does_table_exist
([#90](#90))
([513da9a](513da9a))
* One language model param for test suites, with separate embeddings
param ([#122](#122))
([7b3a297](7b3a297))
* rogue replacement of `name` with `model_name`
([#124](#124))
([efb5fba](efb5fba))
* split plan creation from validation
([#115](#115))
([1d7c388](1d7c388))
* suppress noisy gemini logs
([#76](#76))
([89ce84c](89ce84c))
* Validate udf does not return LogicalType
([#117](#117))
([c1854ba](c1854ba))


### Documentation

* fix expired discord link in contributing.md
([#73](#73))
([fe6fd3d](fe6fd3d))
* notebook version of the example
([#60](#60))
([6f2ad91](6f2ad91))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: typedef-ai-gha[bot] <214539804+typedef-ai-gha[bot]@users.noreply.github.com>
@german-typedef german-typedef mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcallender bcallender bcallender approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@german-typedef @bcallender