fix: use the cloud catalog when doing save_as_table in a cloud session #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
german-typedef
changed the base branch from
07-17-fix_make_catalog_use_sc_method_to_implement_does_table_exist
to
graphite-base/91
german-typedef
force-pushed
the
graphite-base/91
branch
from
5906010 to
c2218e9
Compare
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
from
9d19ab6 to
eac9275
Compare
german-typedef
changed the base branch from
graphite-base/91
to
07-17-fix_make_catalog_use_sc_method_to_implement_does_table_exist
german-typedef
changed the base branch from
07-17-fix_make_catalog_use_sc_method_to_implement_does_table_exist
to
graphite-base/91
german-typedef
force-pushed
the
graphite-base/91
branch
from
c2218e9 to
513da9a
Compare
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
from
eac9275 to
796a233
Compare
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
from
796a233 to
8397d8c
Compare
bcallender
approved these changes
Jul 21, 2025
Contributor
bcallender
left a comment
bcallender
left a comment
There was a problem hiding this comment.
looks fine, just a few minor nits
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
from
8397d8c to
293ea49
Compare
rohitrastogi
suggested changes
Jul 25, 2025
rohitrastogi
left a comment
rohitrastogi
left a comment
There was a problem hiding this comment.
needs one more round of reviews
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
2 times, most recently
from
7646651 to
ec78306
Compare
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
2 times, most recently
from
f040c35 to
b80ea4c
Compare
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
from
b80ea4c to
fdbfa46
Compare
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
3 times, most recently
from
b2b040a to
6b9a23e
Compare
Contributor
Author
|
My bad, this was out for a while. I've addressed all the comments. |
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
from
6b9a23e to
f451b4f
Compare
german-typedef
force-pushed
the
07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
branch
from
4260ef1 to
222310d
Compare
bcallender
reviewed
Aug 27, 2025
| catalog_name: str | ||
| catalog_id: UUID | ||
|
|
||
| CLOUD_SUPPORTED_SCHEMES = ["s3"] |
| return schema_type | ||
|
|
||
| @staticmethod | ||
| def _get_table_location_from_table_identifier(table_identifier: TableIdentifier) -> str: |
Contributor
There was a problem hiding this comment.
wouldn't the location be based on the base location in the catalog? if the user provides a bucket or prefix as the catalog's base location, all of the paths for dbs and tables should be relative to that base location, i would think.
| f"2) Use a different table name.") | ||
| elif table_exists and query_metrics: | ||
| # trunk-ignore-begin(bandit/B101) | ||
| assert mode == "ignore", "only mode to fulfill this invariant is ignore." |
Contributor
There was a problem hiding this comment.
particular reason to choose assert here and not raise an exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for specifying a location when saving DataFrames as tables using a cloud session.
What changed?