Fix logic with check for duplicate container name at level (#19803)

Fix logic with check for duplicate container name at level.

Author: AndyButland

src/Umbraco.Core/Services/EntityTypeContainerService.cs

@@ -107,7 +107,7 @@ public Task<IEnumerable<EntityContainer>> GetAllAsync()
                     return EntityContainerOperationStatus.ParentNotFound;
                 }
 
-                if (_entityContainerRepository.HasDuplicateName(container.ParentId, container.Name!))
+                if (_entityContainerRepository.HasDuplicateName(parentContainer?.Id ?? Constants.System.Root, container.Name!))
                 {
                     return EntityContainerOperationStatus.DuplicateName;
                 }

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/EntityContainerRepository.cs

@@ -149,7 +149,7 @@ public bool HasDuplicateName(int parentId, string name)
     {
         NodeDto nodeDto = Database.FirstOrDefault<NodeDto>(Sql().SelectAll()
             .From<NodeDto>()
-            .Where<NodeDto>(dto => dto.Text == name &&  dto.NodeObjectType == NodeObjectTypeId && dto.ParentId == parentId));
+            .Where<NodeDto>(dto => dto.Text == name && dto.NodeObjectType == NodeObjectTypeId && dto.ParentId == parentId));
 
         return nodeDto is not null;
     }

tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/DataTypeContainerServiceTests.cs

@@ -5,7 +5,6 @@
 using Umbraco.Cms.Core.Serialization;
 using Umbraco.Cms.Core.Services;
 using Umbraco.Cms.Core.Services.OperationStatus;
-using Umbraco.Cms.Infrastructure.Services;
 using Umbraco.Cms.Tests.Common.Testing;
 using Umbraco.Cms.Tests.Integration.Testing;
 
@@ -54,6 +53,26 @@ public async Task Can_Create_Child_Container()
         Assert.AreEqual(root.Id, created.ParentId);
     }
 
+    [TestCase("Existing Child Container", false)]
+    [TestCase("New Child Container", true)]
+    [TestCase("Root Container", true)]
+    public async Task Can_Create_Child_Container_Without_Duplicate_Name_At_Level(string containerName, bool expectSuccess)
+    {
+        EntityContainer root = (await DataTypeContainerService.CreateAsync(null, "Root Container", null, Constants.Security.SuperUserKey)).Result;
+        EntityContainer existingChild = (await DataTypeContainerService.CreateAsync(null, "Existing Child Container", root.Key, Constants.Security.SuperUserKey)).Result;
+
+        var result = await DataTypeContainerService.CreateAsync(null, containerName, root.Key, Constants.Security.SuperUserKey);
+        Assert.AreEqual(expectSuccess, result.Success);
+        if (expectSuccess)
+        {
+            Assert.AreEqual(EntityContainerOperationStatus.Success, result.Status);
+        }
+        else
+        {
+            Assert.AreEqual(EntityContainerOperationStatus.DuplicateName, result.Status);
+        }
+    }
+
     [Test]
     public async Task Can_Create_Container_With_Explicit_Key()
     {