Embedding YouTube in Tiptap adds extra spacing

[Jondahln]

Which Umbraco version are you using?

15.4.1

Bug summary

Embedding YouTube links in Tiptap you will automatically add spacing above and below the element when you update and save the block.

Specifics

When you embed a YouTube link in Tiptap you will automatically get spacing above and below the element. The issue is that every time you update the block it will automatically add extra spacing each time. It seems like it adds an extra paragraph since the spacing will render on the site if you save the block.

Steps to reproduce

1. Create a block that has a Tiptap rich text editor
2. Write two paragraphs
3. Embed a YouTube video between the paragraphs
4. Press save / update
5. Open up the same block again
6. Now there should be extra spacing added

This issue was reproducible in Chrome Version 137

Expected result / actual result

Saving or updating a embedded Youtube link should not add extra spacing in the Tiptap rich text editor

---

This item has been added to our backlog AB#53783

[github-actions]

Hi there @Jondahln!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[leekelleher]

@Jondahln Thanks for reporting this. I'd noticed this behaviour too.

The reason being that the Tiptap RTE has a stricter schema for HTML semantics.
In this case, Embedded Media extension is configured to be an inline type, (meaning that it can be inserted within paragraphs, or aligned with other embeds). However in this case, the YouTube embeds are wrapped in a <div> tag, (which is a block-level HTML element), so when it's inserted inside a <p> tag, the RTE doesn't like it and moves the <div> outside the <p> (which ends up resulting in additional <p> tags before and after the <div>).

Side note: most modern browsers have the same behaviour when rendering markup, e.g. <p><div>Test</div></p> will result in <p></p><div>Test</div><p></p>

Reasons aside, it's still a bug in our Tiptap RTE integration, (for the Embedded Media extension), and I'll look for a fix in an upcoming release.