VariationContext is modified when calling .Url() function on IPublishedContent

[jopperuessink-frontis]

Which Umbraco version are you using?

v16

Bug summary

In my project, I have a piece of code responsible for building a language switcher. To generate this language switcher, I loop through all available languages and call the IPublishedContent.Url(culture: <culture>) function for each one. This allows me to retrieve the URL in the corresponding language so that the language switcher can display all available URLs per language.

What I’ve noticed, however, is that the .Url() function occasionally modifies the VariationContext to the specified culture. I assume this is unintended behavior, as the function is expected to be a getter rather than a modifier.

Specifics

No response

Steps to reproduce

• Create a template (.cshtml)
• Use the ILanguageService to loop through all available languages.
• On the IPublishedContent of the current page, call the .Url(culture) function.
• Observe that, sporadically, the culture is changed to a different language after the loop has finished executing.

Expected result / actual result

Expected:

• The user’s language should not be changed by calling the .Url() function, and the entire page should be rendered in the same language.

Actual:

• The user’s language (VariationContext) is modified when using the .Url() function.
• The page is rendered in multiple languages.

[github-actions]

Hi there @jopperuessink-frontis!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[AndyButland]

I'd be interested to hear if you were able to replicate this on the Umbraco 17 release candidate @jopperuessink-frontis. As it sounds similar to a scenario we found in testing and resolved with #20587.