[17.0.0-rc1]: IPublishedContent .Url() method throws 'Wasn't able to get an UmbracoContext'

[shearer3000]

Which Umbraco version are you using?

17.0.0-rc1

Bug summary

Using a minimal api style endpoint for producing search engine sitemap content, via the route "/sitemap.xml" for example, will throw an exception of  'Wasn't able to get an UmbracoContext' when trying to resolve the IPublishedContent Url()

Specifics

No response

Steps to reproduce

I've cut down this sample code for brevity and just to highlight/reproduce the specific problem

public static class TestApis
{
  public static IEndpointRouteBuilder MapTestApi(this IEndpointRouteBuilder app)
  {

    app.MapGet("sitemap.xml", TestApis.Get);

    return app;
  }

  private static Ok<List<string>> Get(
    [FromServices] IPublishedContentQuery contentQuery
  )
  {
    var homepageIpcs = contentQuery.ContentAtRoot()
                        .Where(x => x.ContentType.Alias.Contains("homepage", StringComparison.InvariantCultureIgnoreCase));
    var pageIpcs = new List<IPublishedContent>();
    pageIpcs.AddRange(homepageIpcs.SelectMany(s => s.DescendantsOrSelf()));
    var urls = pageIpcs.Select(x=>x.Url());
    return TypedResults.Ok(urls.ToList());
  }
}

When the route is "/sitemap.xml" the exception is produced at runtime. When the route is "/sitemap" (ie. without extension) the route executes successfully i.e. Url() works.

Expected result / actual result

Umbraco context in custom routes is available in the same way whether it is extensionless or not

[github-actions]

Hi there @shearer3000!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[shearer3000]

(NB sort of looks similar to #18883 but im not sure if its 100% the same thing)

[nikolajlauridsen]

Hi @shearer3000 👋

For an Umbraco context to exist, the request must run through the Umbraco pipeline. This means looking for matching Umbraco content, which isn't a free operation. To improve performance, we skip this process for client-side requests like JavaScript files, HTML files, anything with a file extension, since there's no real reason to process them. This behaviour is intentional.

However, for cases like yours where you need the Umbraco pipeline to run regardless, you can selectively specify certain routes. See the documentation for more information: https://docs.umbraco.com/umbraco-cms/reference/routing/custom-routes#client-side-requests

Add this to your Program.cs to make it work as intended:

builder.Services.Configure<UmbracoRequestOptions>(options =>
{
    options.HandleAsServerSideRequest = httpRequest => 
        httpRequest.Path.StartsWithSegments("/sitemap.xml");
});

I'll go ahead and close this since it's working as intended. Thanks for reporting! 👍

[shearer3000]

thanks for confirming @nikolajlauridsen