Tiptap RTE: Reduce loading layout shift #19860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that the border only appears once it's ready.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses layout shift issues in the Tiptap Rich Text Editor by adding minimum heights to toolbar components and improving the loading state visual appearance. The changes help reduce the jarring visual effect that occurs when toolbar items load asynchronously.
- Add minimum heights to toolbar rows and groups to prevent vertical layout shift
- Improve loading state by conditionally showing editor border only after content loads
- Update CSS box-sizing and height values to use design system tokens
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tiptap-toolbar.element.ts | Adds minimum heights and box-sizing to toolbar container and groups |
| tiptap-statusbar.element.ts | Adds box-sizing property to statusbar styling |
| input-tiptap.element.ts | Conditionally shows editor border based on loading state and adds data attribute |
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/tiptap-toolbar.element.ts
Show resolved
Hide resolved
iOvergaard
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the issues outlined in #19728 is the layout shift once the Tiptap RTE has loaded.
The main reason for this is that each toolbar item is an extension, which is loaded in asynchronously, and when there are numerous toolbar items, this can visually appear quite jarring.
Important
Issue #19728 should not be resolved by this, as there are other issues to investigate there.
This fix refactors how the toolbar extension items are loaded in, along with adding skeleton UI during loading, a minimum-height for the toolbar's rows and groups has also been added, so that the vertical layout shift is reduced.
How to test?
Try loading the Tiptap RTE on a document before and after this patch. Specifically notice how the toolbar items are loaded in, after the initial load, and then on subsequent loads. A good scenario is to try within a Block List element, either inline or sidebar modal, (it's quicker to see the build-up/tear-down of the RTE component).