fix(logviewer): added timestamp filtering the the AzureTableLogEntity to prevent memory issues

Author: Yinzy00

10/umbraco-cms/fundamentals/backoffice/logviewer.md

@@ -78,12 +78,15 @@ public class AzureTableLogViewer : SerilogLogViewerSourceBase
         var requiredEntities = skip + take;
         IEnumerable<AzureTableLogEntity> results = client.Query<AzureTableLogEntity>().Take(requiredEntities);
 
-        return results
-            .Skip(skip)
-            .Take(take)
-            .Select(x => LogEventReader.ReadFromString(x.Data))
-            .Where(filter.TakeLogEvent)
-            .ToList();
+		return results
+			.Skip(skip)
+			.Take(take)
+			.Select(x => LogEventReader.ReadFromString(x.Data))
+            // Filter by timestamp to avoid retrieving all logs from the table, preventing memory and performance issues
+			.Where(evt => evt.Timestamp >= logTimePeriod.StartTime.Date &&
+				evt.Timestamp <= logTimePeriod.EndTime.Date.AddDays(1).AddSeconds(-1))
+			.Where(filter.TakeLogEvent)
+			.ToList();
     }
 
     public override IReadOnlyList<SavedLogSearch>? GetSavedSearches()

13/umbraco-cms/fundamentals/backoffice/logviewer.md

@@ -80,12 +80,15 @@ public class AzureTableLogViewer : SerilogLogViewerSourceBase
         var requiredEntities = skip + take;
         IEnumerable<AzureTableLogEntity> results = client.Query<AzureTableLogEntity>().Take(requiredEntities);
 
-        return results
-            .Skip(skip)
-            .Take(take)
-            .Select(x => LogEventReader.ReadFromString(x.Data))
-            .Where(filter.TakeLogEvent)
-            .ToList();
+		return results
+			.Skip(skip)
+			.Take(take)
+			.Select(x => LogEventReader.ReadFromString(x.Data))
+            // Filter by timestamp to avoid retrieving all logs from the table, preventing memory and performance issues
+			.Where(evt => evt.Timestamp >= logTimePeriod.StartTime.Date &&
+				evt.Timestamp <= logTimePeriod.EndTime.Date.AddDays(1).AddSeconds(-1))
+			.Where(filter.TakeLogEvent)
+			.ToList();
     }
 
     public override IReadOnlyList<SavedLogSearch>? GetSavedSearches()

14/umbraco-cms/fundamentals/backoffice/logviewer.md

@@ -80,12 +80,15 @@ public class AzureTableLogViewer : SerilogLogViewerSourceBase
         var requiredEntities = skip + take;
         IEnumerable<AzureTableLogEntity> results = client.Query<AzureTableLogEntity>().Take(requiredEntities);
 
-        return results
-            .Skip(skip)
-            .Take(take)
-            .Select(x => LogEventReader.ReadFromString(x.Data))
-            .Where(filter.TakeLogEvent)
-            .ToList();
+		return results
+			.Skip(skip)
+			.Take(take)
+			.Select(x => LogEventReader.ReadFromString(x.Data))
+            // Filter by timestamp to avoid retrieving all logs from the table, preventing memory and performance issues
+			.Where(evt => evt.Timestamp >= logTimePeriod.StartTime.Date &&
+				evt.Timestamp <= logTimePeriod.EndTime.Date.AddDays(1).AddSeconds(-1))
+			.Where(filter.TakeLogEvent)
+			.ToList();
     }
 
     public override IReadOnlyList<SavedLogSearch>? GetSavedSearches()

15/umbraco-cms/fundamentals/backoffice/logviewer.md

@@ -80,12 +80,15 @@ public class AzureTableLogViewer : SerilogLogViewerSourceBase
         var requiredEntities = skip + take;
         IEnumerable<AzureTableLogEntity> results = client.Query<AzureTableLogEntity>().Take(requiredEntities);
 
-        return results
-            .Skip(skip)
-            .Take(take)
-            .Select(x => LogEventReader.ReadFromString(x.Data))
-            .Where(filter.TakeLogEvent)
-            .ToList();
+		return results
+			.Skip(skip)
+			.Take(take)
+			.Select(x => LogEventReader.ReadFromString(x.Data))
+            // Filter by timestamp to avoid retrieving all logs from the table, preventing memory and performance issues
+			.Where(evt => evt.Timestamp >= logTimePeriod.StartTime.Date &&
+				evt.Timestamp <= logTimePeriod.EndTime.Date.AddDays(1).AddSeconds(-1))
+			.Where(filter.TakeLogEvent)
+			.ToList();
     }
 
     public override IReadOnlyList<SavedLogSearch>? GetSavedSearches()