feat: rm keepTriggerConfig option and make it true by default in trigger

Author: CahidArda

src/client/index.test.ts

@@ -237,7 +237,7 @@ describe("workflow client", () => {
               "upstash-workflow-url": "https://requestcatcher.com/api",
               "upstash-delay": "1s",
               "content-type": "application/json",
-              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger",
+              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger,WF_TriggerOnConfig",
               "upstash-forward-upstash-label": "test-label",
               "upstash-label": "test-label",
               "upstash-telemetry-framework": "unknown",
@@ -278,7 +278,6 @@ describe("workflow client", () => {
             retryDelay: "2000",
             notBefore: new Date("2100-01-01T00:00:00Z").getTime() / 1000,
             useFailureFunction: true,
-            keepTriggerConfig: true,
           },
         ]);
         expect(result).toEqual([
@@ -308,7 +307,7 @@ describe("workflow client", () => {
               "upstash-workflow-url": "https://requestcatcher.com/api",
               "upstash-delay": "1s",
               "content-type": "application/json",
-              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger",
+              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger,WF_TriggerOnConfig",
               "upstash-telemetry-framework": "unknown",
               "upstash-telemetry-runtime": expect.stringMatching(/bun@/),
               "upstash-telemetry-sdk": expect.stringContaining("@upstash/workflow"),
@@ -392,7 +391,7 @@ describe("workflow client", () => {
               "upstash-delay": "1s",
               "upstash-failure-callback": "https://requestcatcher.com/some-failure-callback",
               "content-type": "application/json",
-              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger",
+              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger,WF_TriggerOnConfig",
               "upstash-failure-callback-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger",
               "upstash-failure-callback-forward-upstash-workflow-failure-callback": "true",
               "upstash-failure-callback-forward-upstash-workflow-is-failure": "true",

src/client/index.ts

@@ -266,7 +266,6 @@ export class Client {
         telemetry: option.disableTelemetry ? undefined : { sdk: SDK_TELEMETRY },
         delay: option.delay,
         notBefore: option.notBefore,
-        keepTriggerConfig: option.keepTriggerConfig,
       };
     });
     const result = await triggerFirstInvocation(invocations);

src/client/types.ts

@@ -419,13 +419,6 @@ export type TriggerOptions = {
    * Can be used to filter the workflow run logs.
    */
   label?: string;
-  /**
-   * Whether to apply the configuration (flow control,
-   * retries, failure url, retry delay) passed in trigger
-   *
-   * @default false
-   */
-  keepTriggerConfig?: boolean;
   /**
    * By default, Workflow SDK sends telemetry about SDK version, framework or runtime.
    *

src/receiver.test.ts

@@ -206,7 +206,7 @@ describe("receiver", () => {
               destination: WORKFLOW_ENDPOINT,
               headers: {
                 "content-type": "application/json",
-                "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger",
+                "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger,WF_TriggerOnConfig",
                 "upstash-forward-authorization": expect.stringMatching(/Bearer /),
                 "upstash-forward-upstash-signature": expect.any(String),
                 "upstash-forward-upstash-workflow-sdk-version": "1",

src/serve/serve.test.ts

@@ -82,7 +82,7 @@ describe("serve", () => {
             destination: WORKFLOW_ENDPOINT,
             headers: {
               "content-type": "application/json",
-              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger",
+              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger,WF_TriggerOnConfig",
               "upstash-label": labelValue,
               "upstash-forward-upstash-label": labelValue,
               "upstash-flow-control-key": "my-key",
@@ -190,7 +190,8 @@ describe("serve", () => {
                 headers: {
                   "upstash-workflow-sdk-version": "1",
                   "content-type": "application/json",
-                  "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger",
+                  "upstash-feature-set":
+                    "LazyFetch,InitialBody,WF_DetectTrigger,WF_TriggerOnConfig",
                   "upstash-forward-upstash-workflow-sdk-version": "1",
                   "upstash-forward-upstash-workflow-invoke-count": "2",
                   "upstash-retries": "2",

src/workflow-requests.test.ts

@@ -127,7 +127,7 @@ describe("Workflow Requests", () => {
             destination: WORKFLOW_ENDPOINT,
             headers: {
               "content-type": "application/json",
-              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger",
+              "upstash-feature-set": "LazyFetch,InitialBody,WF_DetectTrigger,WF_TriggerOnConfig",
               "upstash-forward-upstash-workflow-sdk-version": "1",
               "upstash-method": "POST",
               "upstash-retries": "0",
@@ -1069,7 +1069,7 @@ describe("Workflow Requests", () => {
             "Upstash-Workflow-Init": "true",
             "Upstash-Workflow-RunId": workflowRunId,
             "Upstash-Workflow-Url": WORKFLOW_ENDPOINT,
-            "Upstash-Feature-Set": "LazyFetch,InitialBody,WF_DetectTrigger",
+            "Upstash-Feature-Set": "LazyFetch,InitialBody,WF_DetectTrigger,WF_TriggerOnConfig",
             [WORKFLOW_PROTOCOL_VERSION_HEADER]: WORKFLOW_PROTOCOL_VERSION,
             "Upstash-Forward-Upstash-Workflow-Sdk-Version": "1",
             "Upstash-Retries": "0",

src/workflow-requests.ts

@@ -40,7 +40,6 @@ type TriggerFirstInvocationParams<TInitialPayload> = {
   invokeCount?: number;
   delay?: PublishRequest["delay"];
   notBefore?: PublishRequest["notBefore"];
-  keepTriggerConfig?: boolean;
 };
 
 export const triggerFirstInvocation = async <TInitialPayload>(
@@ -52,15 +51,7 @@ export const triggerFirstInvocation = async <TInitialPayload>(
   const workflowContextClient = firstInvocationParams[0].workflowContext.qstashClient;
 
   const invocationBatch = firstInvocationParams.map(
-    ({
-      workflowContext,
-      useJSONContent,
-      telemetry,
-      invokeCount,
-      delay,
-      notBefore,
-      keepTriggerConfig,
-    }) => {
+    ({ workflowContext, useJSONContent, telemetry, invokeCount, delay, notBefore }) => {
       const { headers } = getHeaders({
         initHeaderValue: "true",
         workflowConfig: {
@@ -75,7 +66,7 @@ export const triggerFirstInvocation = async <TInitialPayload>(
         },
         invokeCount: invokeCount ?? 0,
         userHeaders: workflowContext.headers,
-        keepTriggerConfig: keepTriggerConfig,
+        keepTriggerConfig: true,
       });
 
       // QStash doesn't forward content-type when passed in `upstash-forward-content-type`