Skip to content

Commit af512b7

Browse files
Merge pull request #93 from utopia-php/fix-utopia-validator-typings
fix(validators): adapt to utopia changes
2 parents 6741e8d + 696bdd3 commit af512b7

File tree

10 files changed

+125
-119
lines changed

10 files changed

+125
-119
lines changed

composer.lock

Lines changed: 108 additions & 102 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Database/Validator/Authorization.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public function __construct($action)
3737
*
3838
* @return string
3939
*/
40-
public function getDescription()
40+
public function getDescription(): string
4141
{
4242
return $this->message;
4343
}
@@ -51,7 +51,7 @@ public function getDescription()
5151
*
5252
* @return bool
5353
*/
54-
public function isValid($permissions)
54+
public function isValid($permissions): bool
5555
{
5656
if (!self::$status) {
5757
return true;

src/Database/Validator/DocumentId.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function __construct(Database $database, string $collection = '')
4242
*
4343
* @return string
4444
*/
45-
public function getDescription()
45+
public function getDescription(): string
4646
{
4747
return $this->message;
4848
}
@@ -56,7 +56,7 @@ public function getDescription()
5656
*
5757
* @return bool
5858
*/
59-
public function isValid($id)
59+
public function isValid($id): bool
6060
{
6161
$document = $this->database->getDocument($this->collection, $id);
6262

src/Database/Validator/Key.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class Key extends Validator
1818
*
1919
* @return string
2020
*/
21-
public function getDescription()
21+
public function getDescription(): string
2222
{
2323
return $this->message;
2424
}
@@ -32,7 +32,7 @@ public function getDescription()
3232
*
3333
* @return bool
3434
*/
35-
public function isValid($value)
35+
public function isValid($value): bool
3636
{
3737
if (!\is_string($value)) {
3838
return false;

src/Database/Validator/Permissions.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class Permissions extends Validator
3838
*
3939
* @return string
4040
*/
41-
public function getDescription()
41+
public function getDescription(): string
4242
{
4343
return $this->message;
4444
}
@@ -52,7 +52,7 @@ public function getDescription()
5252
*
5353
* @return bool
5454
*/
55-
public function isValid($roles)
55+
public function isValid($roles): bool
5656
{
5757
if(!is_array($roles)) {
5858
$this->message = 'Permissions roles must be an array of strings.';

src/Database/Validator/Queries.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public function __construct($validator, $indexes, $strict = true)
5555
*
5656
* @return string
5757
*/
58-
public function getDescription()
58+
public function getDescription(): string
5959
{
6060
return $this->message;
6161
}
@@ -67,7 +67,7 @@ public function getDescription()
6767
* @param mixed $value as array of Query objects
6868
* @return bool
6969
*/
70-
public function isValid($value)
70+
public function isValid($value): bool
7171
{
7272
/**
7373
* Array of attributes from Query->getAttribute()

src/Database/Validator/QueryValidator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function __construct(array $attributes)
5151
*
5252
* @return string
5353
*/
54-
public function getDescription()
54+
public function getDescription(): string
5555
{
5656
return $this->message;
5757
}
@@ -65,7 +65,7 @@ public function getDescription()
6565
*
6666
* @return bool
6767
*/
68-
public function isValid($query)
68+
public function isValid($query): bool
6969
{
7070
// Validate operator
7171
if (!in_array($query->getOperator(), $this->operators)) {

src/Database/Validator/Structure.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ static public function removeFormat(string $name): void
170170
*
171171
* @return string
172172
*/
173-
public function getDescription()
173+
public function getDescription(): string
174174
{
175175
return 'Invalid document structure: '.$this->message;
176176
}
@@ -184,7 +184,7 @@ public function getDescription()
184184
*
185185
* @return bool
186186
*/
187-
public function isValid($document)
187+
public function isValid($document): bool
188188
{
189189
if(!$document instanceof Document) {
190190
$this->message = 'Value must be an instance of Document';

src/Database/Validator/UID.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class UID extends Key
1313
*
1414
* @return string
1515
*/
16-
public function getDescription()
16+
public function getDescription(): string
1717
{
1818
return 'UID must contain at most 36 chars. Valid chars are a-z, A-Z, 0-9, and underscore. Can\'t start with a leading underscore';
1919
}

tests/Database/Format.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class Format extends Text
2121
*
2222
* @return string
2323
*/
24-
public function getDescription()
24+
public function getDescription(): string
2525
{
2626
return 'Value must be a valid email address';
2727
}
@@ -34,7 +34,7 @@ public function getDescription()
3434
* @param mixed $value
3535
* @return bool
3636
*/
37-
public function isValid($value)
37+
public function isValid($value): bool
3838
{
3939
if (!\filter_var($value, FILTER_VALIDATE_EMAIL)) {
4040
return false;

0 commit comments

Comments
 (0)