Skip to content

Commit 2b44c3c

Browse files
committed
docs: add comprehensive TODO for jiff-native migration
Add detailed documentation explaining that the current chrono-based timezone parsing fix is a temporary bandaid solution that: 1. Reintroduces chrono dependencies (conflicts with jiff migration) 2. Fixes critical bug #8976 affecting real users 3. Needs proper jiff-native implementation 4. Includes clear migration plan and risk mitigation This ensures future maintainers understand the trade-offs and have a clear path forward for the proper implementation.
1 parent d717ce8 commit 2b44c3c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/uu/date/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ path = "src/date.rs"
2020

2121
[dependencies]
2222
clap = { workspace = true }
23-
chrono = { workspace = true } # TODO: Eventually we'll want to remove this
23+
chrono = { workspace = true } # TODO: Remove after jiff-native timezone parsing implementation
2424
jiff = { workspace = true, features = [
2525
"tzdb-bundle-platform",
2626
"tzdb-zoneinfo",

src/uu/date/src/date.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,8 @@ fn make_format_string(settings: &Settings) -> &str {
451451
/// Parse a `String` into a `DateTime`.
452452
/// If it fails, return a tuple of the `String` along with its `ParseError`.
453453
// TODO: Convert `parse_datetime` to jiff and remove wrapper from chrono to jiff structures.
454+
// NOTE: Currently uses chrono as bandaid fix for issue #8976 (timezone parsing bug).
455+
// This reintroduces chrono dependencies that were removed in jiff migration.
454456
fn parse_date<S: AsRef<str> + Clone>(
455457
s: S,
456458
) -> Result<Zoned, (String, parse_datetime::ParseDateTimeError)> {

0 commit comments

Comments
 (0)