Skip to content

Commit f75dc15

Browse files
committed
uu/mv: change error msg to be the same as GNU coreutils 9.8-2
1 parent 628655d commit f75dc15

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/uu/mv/locales/en-US.ftl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ mv-error-extra-operand = mv: extra operand {$operand}
3131
mv-error-backup-might-destroy-source = backing up {$target} might destroy source; {$source} not moved
3232
mv-error-will-not-overwrite-just-created = will not overwrite just-created '{$target}' with '{$source}'
3333
mv-error-not-replacing = not replacing {$target}
34-
mv-error-cannot-overwrite = cannot overwrite
34+
mv-error-cannot-overwrite = cannot overwrite {$target}
3535
mv-error-cannot-move = cannot move {$source} to {$target}
36-
mv-error-directory-not-empty = A non-empty directory: {$target} exists at destination
36+
mv-error-directory-not-empty = Directory not empty
3737
mv-error-dangling-symlink = can't determine symlink type, since it is dangling
3838
mv-error-no-symlink-support = your operating system does not support symlinks
3939
mv-error-permission-denied = Permission denied

src/uu/mv/locales/fr-FR.ftl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ mv-error-extra-operand = mv : opérande supplémentaire {$operand}
3131
mv-error-backup-might-destroy-source = sauvegarder {$target} pourrait détruire la source ; {$source} non déplacé
3232
mv-error-will-not-overwrite-just-created = ne va pas écraser le fichier qui vient d'être créé '{$target}' avec '{$source}'
3333
mv-error-not-replacing = ne remplace pas {$target}
34-
mv-error-cannot-overwrite = impossible d'écraser
34+
mv-error-cannot-overwrite = impossible d'écraser ${target}
3535
mv-error-cannot-move = impossible de déplacer {$source} vers {$target}
36-
mv-error-directory-not-empty = Un répertoire non vide : ${target} existe à destination
36+
mv-error-directory-not-empty = Répertoire non vide
3737
mv-error-dangling-symlink = impossible de déterminer le type de lien symbolique, car il est suspendu
3838
mv-error-no-symlink-support = votre système d'exploitation ne prend pas en charge les liens symboliques
3939
mv-error-permission-denied = Permission refusée

src/uu/mv/src/mv.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -675,7 +675,9 @@ fn move_files_into_dir(files: &[PathBuf], target_dir: &Path, options: &Options)
675675
) {
676676
Err(e) if e.to_string().is_empty() => set_exit_code(1),
677677
Err(e) => {
678-
let e = e.map_err_context(|| translate!("mv-error-cannot-overwrite"));
678+
let e = e.map_err_context(
679+
|| translate!("mv-error-cannot-overwrite", "target" => targetpath.quote()),
680+
);
679681
match display_manager {
680682
Some(ref pb) => pb.suspend(|| show!(e)),
681683
None => show!(e),
@@ -754,9 +756,7 @@ fn rename(
754756
if is_empty_dir(to) {
755757
fs::remove_dir(to)?;
756758
} else {
757-
return Err(io::Error::other(
758-
translate!("mv-error-directory-not-empty", "target" => to.quote()),
759-
));
759+
return Err(io::Error::other(translate!("mv-error-directory-not-empty")));
760760
}
761761
}
762762
}

tests/by-util/test_mv.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1463,7 +1463,7 @@ fn test_mv_overwrite_nonempty_dir_error() {
14631463
// GNU: "mv: cannot overwrite 'b': Directory not empty"
14641464

14651465
ucmd.arg(dummy_dir_a).arg(dir_b).fails().stderr_is(format!(
1466-
"mv: cannot overwrite: A non-empty directory: '{dummy_dir_b}' exists at destination\n"
1466+
"mv: cannot overwrite '{dummy_dir_b}': Directory not empty\n"
14671467
));
14681468
}
14691469

0 commit comments

Comments
 (0)