fix(nl): allow repeated flags to match GNU nl behavior (fixes #9132) #9140

naoNao89 · 2025-11-04T07:35:46Z

Fixes #9132. uu-nl now accepts repeated flags like GNU nl. Added args_override_self(true)to all 10 value-accepting arguments.

github-actions · 2025-11-04T07:57:03Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

tests/by-util/test_nl.rs

src/uu/nl/src/nl.rs

src/uu/nl/src/helper.rs

github-actions · 2025-11-05T17:31:30Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

tests/by-util/test_nl.rs

github-actions · 2025-11-07T13:13:51Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

codspeed-hq · 2025-11-08T21:42:50Z

CodSpeed Performance Report

Merging #9140 will not alter performance

_{Comparing naoNao89:fix/nl-repeated-flags-9132 (aff651d) with main (7bcf58d)}

Summary

✅ 123 untouched
⏩ 5 skipped¹

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-11-08T21:52:09Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

tests/by-util/test_nl.rs

github-actions · 2025-11-10T19:48:30Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

tests/by-util/test_nl.rs

github-actions · 2025-11-11T13:21:30Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

cakebaker · 2025-11-11T14:14:33Z

tests/by-util/test_nl.rs

test_repeated_footer_numbering_flag looks good now. Unfortunately, you have undone the previous changes to test_repeated_header_numbering_flag, test_repeated_join_blank_lines_flag, and test_repeated_section_delimiter_flag with the most recent push and the issues I mentioned yesterday are back :|

Tests fixed and passing

Hm, now you have undone the changes to test_repeated_footer_numbering_flag :| The other changes look good.

• Enable args_override_self(true) for repeated flags • Remove unnecessary ArgAction::Append calls • Fix tests to verify last value wins, not just succeeds • Update test output validation for repeated flags Fixes uutils#9132

github-actions · 2025-11-11T18:08:07Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

cakebaker · 2025-11-12T08:12:44Z

tests/by-util/test_nl.rs

+        .args(&["-d", ":", "-d", "|"])
+        .pipe_in("|:|:|:\na\nb\nc")
+        .succeeds()
+        .stdout_is("\n       a\n       b\n       c\n"); // header line not recognized with -d|


The comment is incorrect. The piped in input is recognized as a header, otherwise |:|:|: would show up in the output.

Suggested change

.stdout_is("\n a\n b\n c\n"); // header line not recognized with -d|

.stdout_is("\n a\n b\n c\n");

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

src/uu/nl/src/nl.rs Show resolved Hide resolved

cakebaker reviewed Nov 5, 2025

View reviewed changes

src/uu/nl/src/helper.rs Show resolved Hide resolved

naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from 5238335 to a2db784 Compare November 5, 2025 17:10

cakebaker reviewed Nov 6, 2025

View reviewed changes

tests/by-util/test_nl.rs Show resolved Hide resolved

naoNao89 closed this by deleting the head repository Nov 6, 2025

naoNao89 reopened this Nov 7, 2025

naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from a2db784 to 8f1bd52 Compare November 8, 2025 21:30

cakebaker reviewed Nov 10, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 10, 2025

View reviewed changes

tests/by-util/test_nl.rs Show resolved Hide resolved

cakebaker reviewed Nov 10, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

cakebaker reviewed Nov 10, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from 8f1bd52 to 2d56770 Compare November 10, 2025 19:28

cakebaker reviewed Nov 11, 2025

View reviewed changes

tests/by-util/test_nl.rs Outdated Show resolved Hide resolved

naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from 2d56770 to a4819ba Compare November 11, 2025 12:59

cakebaker reviewed Nov 11, 2025

View reviewed changes

naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from a4819ba to 1ed8792 Compare November 11, 2025 17:44

fix(nl): allow repeated flags to match GNU behavior

aff651d

• Enable args_override_self(true) for repeated flags • Remove unnecessary ArgAction::Append calls • Fix tests to verify last value wins, not just succeeds • Update test output validation for repeated flags Fixes uutils#9132

naoNao89 force-pushed the fix/nl-repeated-flags-9132 branch from 1ed8792 to aff651d Compare November 11, 2025 17:47

cakebaker reviewed Nov 12, 2025

View reviewed changes

	.stdout_is("\n a\n b\n c\n"); // header line not recognized with -d\|
	.stdout_is("\n a\n b\n c\n");

Uh oh!

fix(nl): allow repeated flags to match GNU nl behavior (fixes #9132) #9140

Are you sure you want to change the base?

fix(nl): allow repeated flags to match GNU nl behavior (fixes #9132) #9140

Conversation

naoNao89 commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

codspeed-hq bot commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #9140 will not alter performance

Summary

Footnotes

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

cakebaker Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

naoNao89 Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

naoNao89 Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

cakebaker Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

cakebaker Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

naoNao89 commented Nov 4, 2025 •

edited

Loading

codspeed-hq bot commented Nov 8, 2025 •

edited

Loading

cakebaker Nov 12, 2025 •

edited

Loading