Skip to content

Conversation

@ZheSun88
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025

AI Language Review

The main change across the files appears to be the swapping of javax.annotation.Nonnull with jakarta.annotation.Nonnull. There do not seem to be any errors or issues with this change, as long as the environment is configured to handle jakarta.annotation correctly. Therefore, I have no suggestions or required improvements to note.

""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be already aware, but starting the docs in dev mode results in this:

Caused by: java.lang.RuntimeException: DevModeHandlerManager not found, but dev server is enabled. Either disable by setting vaadin.frontend.hotdeploy=false (and run the build-frontend maven goal) or add 'com.vaadin.vaadin-dev-server' dependency or include it transitively via 'com.vaadin.vaadin-dev'.
        at com.vaadin.flow.spring.VaadinServletContextInitializer$DevModeServletContextListener.failFastContextInitialized(VaadinServletContextInitializer.java:528) ~[vaadin-spring-25.0.0-beta7.jar:na]
        at com.vaadin.flow.spring.VaadinServletContextInitializer$FailFastServletContextListener.contextInitialized(VaadinServletContextInitializer.java:202) ~[vaadin-spring-25.0.0-beta7.jar:na]
        ... 44 common frames omitted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. let us add the vaadin-dev dependency, it has been removed from vaadin-spring-boot-starter in this beta7 release.

also i have updated the project to beta8.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vaadin-dev should be optional I think, otherwise you pull it into the production build. This is what a v25 starter has:

        <dependency>
            <groupId>com.vaadin</groupId>
            <artifactId>vaadin-dev</artifactId>
            <optional>true</optional>
        </dependency>

@ZheSun88 ZheSun88 changed the title chore: update vaadin 25.0.0-beta7 chore: update vaadin 25.0.0-beta8 Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants