-
Notifications
You must be signed in to change notification settings - Fork 214
refactor: update Avatar page to Aura theme #4848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AI Language ReviewThe changes in the submitted code and documentation files do not contain any issues that require further improvement. The modifications maintain clarity, accuracy, and completeness, adhering to the stated guidelines while preserving a professional and friendly tone. |
| |Aura, Lumo | ||
|
|
||
| |Avatar Group overlap border | ||
| |Avatar Group overlap border width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property is marked as deprecated in the source CSS, should we maybe remove it from here?
| [cols="1,2,2"] | ||
| |=== | ||
| | Feature | Property | Default Value | ||
| | Feature | Property | Supported by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --vaadin-avatar-group-gap custom CSS property is missing (also supported by Lumo).
| |Avatar Group overlap border width | ||
| |`--vaadin-avatar-group-overlap-border` | ||
| |`2px` | ||
| |Lumo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove or change "User Color Properties" below as that table lists Lumo default values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the list but remove the default values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Also, in Lumo we only have 7 colors (0-6) but in base styles we have 10 (0-9).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't realize that. Perhaps we should add 3 more to Lumo.
|
Closing in favor of #4862 |
Updates the Avatar page and examples to use the Aura theme.
Noteworthy changes: