Skip to content

Conversation

@sissbruecker
Copy link
Contributor

Updates the Avatar page and examples to use the Aura theme.

Noteworthy changes:

  • Removed avatar size variant example as it isn't supported by Aura
  • Removed avatar menu bar example, included similar popover user menu example instead. That one is quite broken, but should be cleaned up when updating popover examples.

@github-actions
Copy link

AI Language Review

The changes in the submitted code and documentation files do not contain any issues that require further improvement. The modifications maintain clarity, accuracy, and completeness, adhering to the stated guidelines while preserving a professional and friendly tone.

|Aura, Lumo

|Avatar Group overlap border
|Avatar Group overlap border width
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is marked as deprecated in the source CSS, should we maybe remove it from here?

[cols="1,2,2"]
|===
| Feature | Property | Default Value
| Feature | Property | Supported by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --vaadin-avatar-group-gap custom CSS property is missing (also supported by Lumo).

|Avatar Group overlap border width
|`--vaadin-avatar-group-overlap-border`
|`2px`
|Lumo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove or change "User Color Properties" below as that table lists Lumo default values?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the list but remove the default values.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Also, in Lumo we only have 7 colors (0-6) but in base styles we have 10 (0-9).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't realize that. Perhaps we should add 3 more to Lumo.

@sissbruecker
Copy link
Contributor Author

Closing in favor of #4862

@sissbruecker sissbruecker deleted the refactor/aura-theme-avatar branch December 1, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants