Skip to content

24.8.8 broken #10239

@mattheol

Description

@mattheol

Description

Using 24.8.8 i get weird bug.

File: vaadin-themable-mixin.js
Function: updateComponentStyles
Code line: template.content.getElementById(STYLE_ID).textContent = getCssText(componentClass.getStylesForThis());

When I used 24.8.7 everything worked. After 24.8.8 release 24.8 version throws error during runtime.
When I change my package.json "@vaadin/vaadin-core": "24.8.7" it doesn't work, because some components are still installed as 24.8.8, with vaadin-themable-mixin included. Currently my solution is to downgrade to ^24.7.0

Error:
TypeError: Cannot set properties of null (setting 'textContent')
at updateComponentStyles (vaadin-themable-mixin.js:158:1)
at vaadin-themable-mixin.js:233:1
at Set.forEach ()
at registerStyles (vaadin-themable-mixin.js:214:1)
at ./node_modules/@vaadin/upload/node_modules/@vaadin/progress-bar/theme/lumo/vaadin-progress-bar-styles.js (vaadin-progress-bar-styles.js:7:15)
at webpack_require (bootstrap:19:1)
at ./node_modules/@vaadin/upload/theme/lumo/vaadin-upload-styles.js (vaadin-upload.js:220:19)
at webpack_require (bootstrap:19:1)
at ./node_modules/@vaadin/upload/theme/lumo/vaadin-upload.js (vaadin-upload-styles.js:192:97)
at webpack_require (bootstrap:19:1)

Expected outcome

Bug should be resolved to use 24.8 version

Minimal reproducible example

.

Steps to reproduce

.

Environment

Vaadin version(s): 24.8
OS: MacOS

Browsers

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions