tidy tests

Author: adam-fowler

Tests/ValkeyTests/ValkeyConnectionTests.swift

@@ -161,6 +161,7 @@ struct ConnectionTests {
         try await channel.closeFuture.get()
     }
 
+    @Test
     func testPipeline() async throws {
         let channel = NIOAsyncTestingChannel()
         let logger = Logger(label: "test")
@@ -170,9 +171,13 @@ struct ConnectionTests {
             SET(key: "foo", value: "bar"),
             GET(key: "foo")
         )
-        let outbound = try await channel.waitForOutboundWrite(as: ByteBuffer.self)
-        #expect(String(buffer: outbound) == "*3\r\n$3\r\nSET\r\n$3\r\nfoo\r\n$3\r\nbar\r\n*2\r\n$3\r\nGET\r\n$3\r\nfoo\r\n")
-        try await channel.writeInbound(ByteBuffer(string: "+OK\r\n$3\r\nbar\r\n"))
+        var outbound = try await channel.waitForOutboundWrite(as: ByteBuffer.self)
+        let set = RESPToken(.command(["SET", "foo", "bar"])).base
+        #expect(outbound.readSlice(length: set.readableBytes) == set)
+        #expect(outbound == RESPToken(.command(["GET", "foo"])).base)
+        try await channel.writeInbound(RESPToken(.simpleString("OK")).base)
+        try await channel.writeInbound(RESPToken(.bulkString("bar")).base)
+
         #expect(try await results.1.get()?.decode(as: String.self) == "bar")
     }
 
@@ -186,9 +191,13 @@ struct ConnectionTests {
             SET(key: "foo", value: "bar"),
             GET(key: "foo")
         )
-        let outbound = try await channel.waitForOutboundWrite(as: ByteBuffer.self)
-        #expect(String(buffer: outbound) == "*3\r\n$3\r\nSET\r\n$3\r\nfoo\r\n$3\r\nbar\r\n*2\r\n$3\r\nGET\r\n$3\r\nfoo\r\n")
-        try await channel.writeInbound(ByteBuffer(string: "+OK\r\n!10\r\nBulkError!\r\n"))
+        var outbound = try await channel.waitForOutboundWrite(as: ByteBuffer.self)
+        let set = RESPToken(.command(["SET", "foo", "bar"])).base
+        #expect(outbound.readSlice(length: set.readableBytes) == set)
+        #expect(outbound == RESPToken(.command(["GET", "foo"])).base)
+        try await channel.writeInbound(RESPToken(.simpleString("OK")).base)
+        try await channel.writeInbound(RESPToken(.bulkError("BulkError!")).base)
+
         let results = await asyncResults
         #expect(throws: ValkeyClientError(.commandError, message: "BulkError!")) { try results.1.get() }
     }