-
Notifications
You must be signed in to change notification settings - Fork 18
Transactions #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Transactions #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Pull request no significant performance differences ✅ SummaryNew baseline 'pull_request' is WITHIN the 'main' baseline thresholds. Full Benchmark ComparisonComparing results between 'main' and 'pull_request'ValkeyBenchmarksGET benchmark metricsMalloc (total): results within specified thresholds, fold down for details.
HashSlot – {user}.whatever metricsMalloc (total): results within specified thresholds, fold down for details.
ValkeyCommandEncoder – Command with 7 words metricsMalloc (total): results within specified thresholds, fold down for details.
ValkeyCommandEncoder – Simple GET metricsMalloc (total): results within specified thresholds, fold down for details.
ValkeyCommandEncoder – Simple MGET 15 keys metricsMalloc (total): results within specified thresholds, fold down for details.
|
93e5e08 to
7d42af4
Compare
fabianfett
approved these changes
May 6, 2025
adam-fowler
added a commit
that referenced
this pull request
Jul 11, 2025
* Transactions * Add wrapping TransactionCommand to avoid Response conversion * Add RESPToken.convertingWithErrors * transaction returns array of Results * Add tests for pipeline/transaction errors * Redo transactions, to iterate result array * Edits after rebasing renaming of symbols * ValkeyRawResponseCommand
adam-fowler
added a commit
that referenced
this pull request
Jul 14, 2025
* Transactions * Add wrapping TransactionCommand to avoid Response conversion * Add RESPToken.convertingWithErrors * transaction returns array of Results * Add tests for pipeline/transaction errors * Redo transactions, to iterate result array * Edits after rebasing renaming of symbols * ValkeyRawResponseCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter packs are crashing the compiler again, so added another autogenerated set of functions to implement transactions. These are basically pipelined commands with a MULTI at the start and an EXEC at the end. The EXEC returns the responses for queued commands in-between.