Skip to content

Conversation

@adam-fowler
Copy link
Collaborator

@adam-fowler adam-fowler commented Apr 23, 2025

Parameter packs are crashing the compiler again, so added another autogenerated set of functions to implement transactions. These are basically pipelined commands with a MULTI at the start and an EXEC at the end. The EXEC returns the responses for queued commands in-between.

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '9fd286b83d9b' with 2 'x86_64' processors with 7 GB memory, running:
#12~24.04.1-Ubuntu SMP Mon Mar 10 19:00:39 UTC 2025

ValkeyBenchmarks

GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4 4 4 4 4 12 12 11
pull_request 4 4 4 4 4 12 12 11
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 22
pull_request 0 0 0 0 0 0 0 22
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 747
pull_request 0 0 0 0 0 0 0 746
Δ 0 0 0 0 0 0 0 -1
Improvement % 0 0 0 0 0 0 0 -1

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 1946
pull_request 0 0 0 0 0 0 0 1936
Δ 0 0 0 0 0 0 0 -10
Improvement % 0 0 0 0 0 0 0 -10

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 364
pull_request 0 0 0 0 0 0 0 362
Δ 0 0 0 0 0 0 0 -2
Improvement % 0 0 0 0 0 0 0 -2

@adam-fowler adam-fowler force-pushed the transactions branch 5 times, most recently from 93e5e08 to 7d42af4 Compare April 30, 2025 11:15
@adam-fowler adam-fowler requested a review from fabianfett April 30, 2025 11:16
@adam-fowler adam-fowler merged commit 016b517 into main May 6, 2025
3 checks passed
@adam-fowler adam-fowler deleted the transactions branch May 6, 2025 09:45
adam-fowler added a commit that referenced this pull request Jul 11, 2025
* Transactions

* Add wrapping TransactionCommand to avoid Response conversion

* Add RESPToken.convertingWithErrors

* transaction returns array of Results

* Add tests for pipeline/transaction errors

* Redo transactions, to iterate result array

* Edits after rebasing renaming of symbols

* ValkeyRawResponseCommand
adam-fowler added a commit that referenced this pull request Jul 14, 2025
* Transactions

* Add wrapping TransactionCommand to avoid Response conversion

* Add RESPToken.convertingWithErrors

* transaction returns array of Results

* Add tests for pipeline/transaction errors

* Redo transactions, to iterate result array

* Edits after rebasing renaming of symbols

* ValkeyRawResponseCommand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants