Add support for ResponseController SetReadDeadline and SetWriteDeadline ?

[fcx-mrogez]

What would it take to support ResponseController { SetReadDeadline, SetWriteDeadline } in fasthttp adaptor ?
Would calling the respective methods on the "w.handlerConn" [1] (with proper locking) be enough to implement them ?

My use case is when mixing tusd with fiber I use the provided adaptor.HTTPHandler whose ResponseWriter doesn't support the SetReadDeadline / SetWriteDeadline methods. This clutters the logs because of unsupported network features and kind of restrict our handling of timeouts.
To work around this I've re-implemented a simple adaptor with dummy implementation for SetReadDeadline / SetWriteDeadline but I'd like to see the root cause addressed instead of working around it.

Useful links:
[1] https://github.com/valyala/fasthttp/blob/master/fasthttpadaptor/adaptor.go#L279

[erikdubbelboer]

It's not that simple I'm afraid. w.handlerConn is only set when the connection is hijacked. You would need to add a method to RequestCtx so you can call it on w.ctx instead.

Also keep in mind that the read deadline will only do something if body streaming is enabled. In the default mode fasthttp will first read the whole request before running the handler. It will also only write when the handler is done, so setting the write deadline only does something when the handler has finished.

I don't have time to work on this myself, a pull request is always welcome.

[fcx-mrogez]

Thanks for your answer. It indeed, feels a bit more complex than what I though :)
I don't really feel confident doing a PR right now and my current workaround may prove "good enough". If I get the chance to revisit this part later I'll see if I can submit something.