vite: Fix HMR invalidation #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de60b4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
askoufis
commented
Oct 1, 2024
Comment on lines
-9
to
-14
| // Uncomment to enable HMR with Vite | ||
| // if (import.meta.hot) { | ||
| // import.meta.hot.accept('./features.css', () => { | ||
| // render(); | ||
| // }); | ||
| // } |
There was a problem hiding this comment.
This doesn't belong here anymore since this file no longer imports features.css.ts.
askoufis
commented
Oct 1, 2024
Comment on lines
+14
to
+18
| // @ts-expect-error Vite env not defined | ||
| if (import.meta.hot) { | ||
| // @ts-expect-error Vite env not defined | ||
| import.meta.hot.accept(); | ||
| } |
There was a problem hiding this comment.
Self-accepting is fine here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1481.
#1438 broke HMR invalidation for files that don't end in
.css.ts, e.g..css.tsxwhich is a valid, though uncommon, VE file extension.This PR fixes this issue, as well as enables vite HMR for the
featuresfixture to enable easier testing of HMR in the future.