Skip to content

Commit 1661269

Browse files
committed
Rename _RidFanOut to IsOuterBuild and make it a public property.
Closes #68.
1 parent b98a110 commit 1661269

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

src/sdk/build/Vezel.Zig.Sdk.Build.targets

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<Project>
22
<PropertyGroup>
3-
<_RealOrFanOutBuild>_InnerBuild</_RealOrFanOutBuild>
4-
<_RealOrFanOutBuild Condition="'$(_RidFanOut)' == 'true'">_FanOutBuild</_RealOrFanOutBuild>
3+
<_InnerOrOuterBuild>_InnerBuild</_InnerOrOuterBuild>
4+
<_InnerOrOuterBuild Condition="'$(IsOuterBuild)' == 'true'">_OuterBuild</_InnerOrOuterBuild>
55
</PropertyGroup>
66

77
<Target Name="Build"
8-
DependsOnTargets="$(_RealOrFanOutBuild)"
8+
DependsOnTargets="$(_InnerOrOuterBuild)"
99
Condition="'$(_InvalidConfigurationWarning)' != 'true'" />
1010

11-
<Target Name="_FanOutBuild">
11+
<Target Name="_OuterBuild">
1212
<ItemGroup>
1313
<_RuntimeIdentifiers Include="$(RuntimeIdentifiers)" />
1414
<_InnerProjects Include="$(MSBuildProjectFullPath)"

src/sdk/build/Vezel.Zig.Sdk.Clean.targets

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
</ItemGroup>
66

77
<PropertyGroup>
8-
<_RealOrFanOutClean>_InnerClean</_RealOrFanOutClean>
9-
<_RealOrFanOutClean Condition="'$(_RidFanOut)' == 'true'">_FanOutClean</_RealOrFanOutClean>
8+
<_InnerOrOuterClean>_InnerClean</_InnerOrOuterClean>
9+
<_InnerOrOuterClean Condition="'$(IsOuterBuild)' == 'true'">_OuterClean</_InnerOrOuterClean>
1010
</PropertyGroup>
1111

1212
<Target Name="Clean"
13-
DependsOnTargets="$(_RealOrFanOutClean)"
13+
DependsOnTargets="$(_InnerOrOuterClean)"
1414
Condition="'$(_InvalidConfigurationWarning)' != 'true'" />
1515

16-
<Target Name="_FanOutClean">
16+
<Target Name="_OuterClean">
1717
<ItemGroup>
1818
<_RuntimeIdentifiers Include="$(RuntimeIdentifiers)" />
1919
<_InnerProjects Include="$(MSBuildProjectFullPath)"

src/sdk/build/Vezel.Zig.Sdk.Overrides.targets

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@
1818

1919
<!--
2020
If a RuntimeIdentifier value has not been set, it means the Build, Clean,
21-
and Publish targets should fan out and run for every RID supported by the
21+
and Publish targets should run inner builds for every RID supported by the
2222
project. That said, for running and testing, we still need to run natively
23-
by default, so we still have to set a default RID. We use _RidFanOut to
24-
indicate whether the fan-out behavior is required.
23+
by default, so we still have to set a default RID. We use IsOuterBuild to
24+
indicate whether inner builds are required.
2525
-->
2626
<PropertyGroup Condition="'$(RuntimeIdentifier)' == ''">
2727
<RuntimeIdentifier>$(NETCoreSdkPortableRuntimeIdentifier)</RuntimeIdentifier>
28-
<_RidFanOut>true</_RidFanOut>
28+
<IsOuterBuild>true</IsOuterBuild>
2929
</PropertyGroup>
3030
</Project>

src/sdk/build/Vezel.Zig.Sdk.Publish.targets

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<Project>
22
<PropertyGroup>
3-
<_RealOrFanOutPublish>_InnerPublish</_RealOrFanOutPublish>
4-
<_RealOrFanOutPublish Condition="'$(_RidFanOut)' == 'true'">_FanOutPublish</_RealOrFanOutPublish>
3+
<_InnerOrOuterPublish>_InnerPublish</_InnerOrOuterPublish>
4+
<_InnerOrOuterPublish Condition="'$(IsOuterBuild)' == 'true'">_OuterPublish</_InnerOrOuterPublish>
55
</PropertyGroup>
66

77
<Target Name="Publish"
8-
DependsOnTargets="$(_RealOrFanOutPublish)"
8+
DependsOnTargets="$(_InnerOrOuterPublish)"
99
Condition="'$(_InvalidConfigurationWarning)' != 'true'" />
1010

11-
<Target Name="_FanOutPublish">
11+
<Target Name="_OuterPublish">
1212
<ItemGroup>
1313
<_RuntimeIdentifiers Include="$(RuntimeIdentifiers)" />
1414
<_InnerProjects Include="$(MSBuildProjectFullPath)"
@@ -32,6 +32,6 @@
3232
Importance="high" />
3333

3434
<AllowEmptyTelemetry EventName="PublishProperties"
35-
EventData="PublishReadyToRun=$(PublishReadyToRun); PublishTrimmed=$(PublishTrimmed); PublishSingleFile=$(PublishSingleFile)" />
35+
EventData="PublishReadyToRun=$(PublishReadyToRun); PublishTrimmed=$(PublishTrimmed); PublishSingleFile=$(PublishSingleFile); PublishAot=$(PublishAot); PublishProtocol=$(PublishProtocol)" />
3636
</Target>
3737
</Project>

0 commit comments

Comments
 (0)