Skip to content

API break with commit [Fixed a bug that caused an allocation error] #38

@kwizart

Description

@kwizart
          [Fixed a bug that caused an allocation error](https://github.com/videolabs/libspatialaudio/pull/24/commits/10e70839a9ad019e455c48c9d2bf93016ba37633)

This commit breaks API with vlc-3.x
Is there a way to avoid the API break ?

audio_filter/channel_mixer/spatialaudio.cpp: In function 'int Open(vlc_object_t*)':
audio_filter/channel_mixer/spatialaudio.cpp:512:33: error: no matching function for call to 'CAmbisonicZoomer::Configure(unsigned int&, bool, int)'
  512 |     if (!p_sys->zoomer.Configure(p_sys->i_order, true, 0))
      |          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/spatialaudio/AmbisonicProcessor.h:22,
                 from /usr/include/spatialaudio/Ambisonics.h:28,
                 from audio_filter/channel_mixer/spatialaudio.cpp:43:
/usr/include/spatialaudio/AmbisonicZoomer.h:40:18: note: candidate: 'virtual bool CAmbisonicZoomer::Configure(unsigned int, bool, unsigned int, unsigned int)'
   40 |     virtual bool Configure(unsigned nOrder, bool b3D, unsigned nBlockSize, unsigned nMisc);
      |                  ^~~~~~~~~
/usr/include/spatialaudio/AmbisonicZoomer.h:40:18: note:   candidate expects 4 arguments, 3 provided
make[4]: *** [Makefile:26640: audio_filter/channel_mixer/libspatialaudio_plugin_la-spatialaudio.lo] Error 1

Originally posted by @kwizart in #24 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions