Add none temp param test case

Author: pamella

tests/test_helpers/test_assistants.py

@@ -289,70 +289,95 @@ class DefaultTempAssistant(AIAssistant):
 
     mock_chat_openai.assert_called_once_with(
         model="gpt-test",
-        temperature=assistant.temperature,
+        temperature=1.0,
         model_kwargs={},
     )
+
     AIAssistant.clear_cls_registry()
 
 
 @patch("django_ai_assistant.helpers.assistants.ChatOpenAI")
-def test_AIAssistant_get_llm_custom_temperature(mock_chat_openai):
+def test_AIAssistant_get_llm_custom_float_temperature(mock_chat_openai):
     custom_temperature = 0.5
 
-    class CustomTempAssistant(AIAssistant):
-        id = "custom_temp_assistant"  # noqa: A003
-        name = "Custom Temp Assistant"
+    class CustomFloatTempAssistant(AIAssistant):
+        id = "custom_float_temp_assistant"  # noqa: A003
+        name = "Custom Float Temp Assistant"
         instructions = "Instructions"
         model = "gpt-test"
         temperature = custom_temperature
 
-    assistant = CustomTempAssistant()
+    assistant = CustomFloatTempAssistant()
     assistant.get_llm()
 
     mock_chat_openai.assert_called_once_with(
         model="gpt-test",
         temperature=custom_temperature,
         model_kwargs={},
     )
+
     AIAssistant.clear_cls_registry()
 
 
 @patch("django_ai_assistant.helpers.assistants.ChatOpenAI")
-def test_AIAssistant_get_llm_override_get_temperature(mock_chat_openai):
+def test_AIAssistant_get_llm_override_get_temperature_with_float(mock_chat_openai):
     custom_temperature = 0.5
 
-    class OverrideGetTempAssistant(AIAssistant):
-        id = "override_temp_assistant"  # noqa: A003
-        name = "Override Temp Assistant"
+    class OverrideGetFloatTempAssistant(AIAssistant):
+        id = "override_get_float_temp_assistant"  # noqa: A003
+        name = "Override Get Float Temp Assistant"
         instructions = "Instructions"
         model = "gpt-test"
 
         def get_temperature(self) -> float | None:
             return custom_temperature
 
-    assistant = OverrideGetTempAssistant()
+    assistant = OverrideGetFloatTempAssistant()
     assistant.get_llm()
 
     mock_chat_openai.assert_called_once_with(
         model="gpt-test",
         temperature=custom_temperature,
         model_kwargs={},
     )
+
+    AIAssistant.clear_cls_registry()
+
+
+@patch("django_ai_assistant.helpers.assistants.ChatOpenAI")
+def test_AIAssistant_get_llm_custom_none_temperature(mock_chat_openai):
+    class CustomNoneTempAssistant(AIAssistant):
+        id = "custom_none_temp_assistant"  # noqa: A003
+        name = "Custom None Temp Assistant"
+        instructions = "Instructions"
+        model = "gpt-test"
+        temperature = None
+
+    assistant = CustomNoneTempAssistant()
+    assistant.get_llm()
+
+    mock_chat_openai.assert_called_once_with(
+        model="gpt-test",
+        model_kwargs={},
+    )
+    _, call_kwargs = mock_chat_openai.call_args
+    assert "temperature" not in call_kwargs
+
     AIAssistant.clear_cls_registry()
 
 
 @patch("django_ai_assistant.helpers.assistants.ChatOpenAI")
-def test_AIAssistant_get_llm_none_temperature(mock_chat_openai):
-    class NoneTempAssistant(AIAssistant):
-        id = "none_temp_assistant"  # noqa: A003
-        name = "None Temp Assistant"
+def test_AIAssistant_get_llm_override_get_temperature_with_none(mock_chat_openai):
+    class OverrideGetNoneTempAssistant(AIAssistant):
+        id = "override_get_none_temp_assistant"  # noqa: A003
+        name = "Override Get None Temp Assistant"
         instructions = "Instructions"
         model = "gpt-test"
 
         def get_temperature(self) -> float | None:
             return None
 
-    assistant = NoneTempAssistant()
+    assistant = OverrideGetNoneTempAssistant()
     assistant.get_llm()
 
     mock_chat_openai.assert_called_once_with(
@@ -362,7 +387,7 @@ def get_temperature(self) -> float | None:
     _, call_kwargs = mock_chat_openai.call_args
     assert "temperature" not in call_kwargs
 
-    AIAssistant.clear_cls_registry()  # Clean up registry
+    AIAssistant.clear_cls_registry()
 
 
 @pytest.mark.vcr