Skip to content

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Sep 19, 2025

Description

This PR fixes 5 test packages which were not following @vitejs/ scope convention. When violated, CI error looks like this https://github.com/vitejs/vite/actions/runs/17849457324/job/50755068346#step:11:19

Error: Found private packages without @vitejs/ prefix:
  - docs (/home/runner/work/vite/vite/docs)
  - dep (/home/runner/work/vite/vite/playground/css/pkg-dep)
  - blue-app (/home/runner/work/vite/vite/playground/css/postcss-caching/blue-app)
  - green-app (/home/runner/work/vite/vite/playground/css/postcss-caching/green-app)
  - nested-external-cjs (/home/runner/work/vite/vite/playground/ssr-deps/nested-external-cjs)

This seems to help not getting flagged security issue etc. when there are real packages exist and getting compromised.

@hi-ogawa hi-ogawa changed the title ci: ensure @vitejs/ scope for private packages names chore: ensure @vitejs/ scope for private packages names Sep 19, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review September 19, 2025 06:17
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure we need a CI step to catch this, we could manually ensure to use scope going forward. The rest of the changes looks fine to me though.

@hi-ogawa
Copy link
Contributor Author

Right, I'm fine either way. AI just wrote this job and that was it 😀

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Sep 20, 2025
@sapphi-red
Copy link
Member

I think we can go without the check in the CI.

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red enabled auto-merge (squash) September 20, 2025 12:54
@sapphi-red sapphi-red merged commit bf3b1f6 into vitejs:main Sep 20, 2025
16 checks passed
@hi-ogawa hi-ogawa deleted the ci-scoped-private-package branch September 21, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants