-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
chore: ensure @vitejs/
scope for private packages names
#20801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vitejs/
scope for private packages names@vitejs/
scope for private packages names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so sure we need a CI step to catch this, we could manually ensure to use scope going forward. The rest of the changes looks fine to me though.
Right, I'm fine either way. AI just wrote this job and that was it 😀 |
I think we can go without the check in the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This PR fixes 5 test packages which were not following
@vitejs/
scope convention. When violated, CI error looks like this https://github.com/vitejs/vite/actions/runs/17849457324/job/50755068346#step:11:19This seems to help not getting flagged security issue etc. when there are real packages exist and getting compromised.