Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Dec 5, 2025

What this PR does / why we need it?

Corrected the vllm tag, which should have been in v0.11.0

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: wangli <[email protected]>
@Potabk
Copy link
Collaborator Author

Potabk commented Dec 5, 2025

Sorry for everybody, my fault!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an inconsistency in the vLLM version used for the OpenEuler build environment. By changing the VLLM_TAG from v0.11.2 to v0.11.0 in Dockerfile.openEuler, it aligns the version with all other Dockerfiles in the repository, such as Dockerfile, Dockerfile.a3, and Dockerfile.310p. This correction ensures a consistent vLLM dependency across different target devices and operating systems, which is crucial for predictable builds and behavior. The change is simple, targeted, and appears correct. I have no further recommendations.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wangxiyuan wangxiyuan merged commit 2598124 into vllm-project:v0.11.0-dev Dec 6, 2025
9 checks passed
Clorist33 pushed a commit to Clorist33/vllm-ascend that referenced this pull request Dec 9, 2025
…ce. (vllm-project#4745)

### What this PR does / why we need it?
Corrected the vllm tag, which should have been in v0.11.0


Signed-off-by: wangli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants