Skip to content

Commit b4444ee

Browse files
committed
Fix lint errors in autotune_helion_kernels.py
- Convert f-string logging to proper format strings (G004) - Fix line length violations (E501) - Use dict iteration instead of .keys() (SIM118) - Break long help text into multiple lines All pre-commit checks now pass successfully. Signed-off-by: Yanan Cao <[email protected]>
1 parent 03878e2 commit b4444ee

File tree

1 file changed

+30
-23
lines changed

1 file changed

+30
-23
lines changed

scripts/autotune_helion_kernels.py

Lines changed: 30 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,7 @@ def autotune_kernel(
139139
# Skip enabled check during autotuning - we want to force autotune for
140140
# Helion kernels. The issue is that the compilation config is being
141141
# reset to ['none'] by system defaults
142-
logger.info(
143-
"Forcing autotuning for %s (bypassing enabled check)", kernel_name
144-
)
142+
logger.info("Forcing autotuning for %s (bypassing enabled check)", kernel_name)
145143

146144
kernel_instance = op_cls()
147145

@@ -150,7 +148,7 @@ def autotune_kernel(
150148
logger.info(
151149
"Will generate %d configs: %s",
152150
len(autotune_inputs),
153-
list(autotune_inputs.keys())
151+
list(autotune_inputs.keys()),
154152
)
155153

156154
# Filter out existing configs (unless forcing)
@@ -170,16 +168,19 @@ def autotune_kernel(
170168
if existing_configs and configs_to_autotune:
171169
logger.info(
172170
"Found existing configs for %s, will autotune remaining: %s",
173-
existing_configs, list(configs_to_autotune.keys())
171+
existing_configs,
172+
list(configs_to_autotune.keys()),
174173
)
175174
elif existing_configs and not configs_to_autotune:
176175
logger.info(
177-
f"All configs already exist for {existing_configs}, use --force to re-generate"
176+
"All configs already exist for %s, use --force to re-generate",
177+
existing_configs,
178178
)
179179
return True
180180
elif not existing_configs:
181181
logger.info(
182-
f"No existing configs found, will autotune all: {list(configs_to_autotune.keys())}"
182+
"No existing configs found, will autotune all: %s",
183+
list(configs_to_autotune.keys()),
183184
)
184185

185186
if not configs_to_autotune:
@@ -202,19 +203,22 @@ def autotune_kernel(
202203
kernel_instance.__class__, config_key, config
203204
)
204205
saved_configs.append(config_key)
205-
logger.info(f"Saved config {config_key} to: {config_path}")
206+
logger.info("Saved config %s to: %s", config_key, config_path)
206207
except Exception as e:
207-
logger.error(f"Failed to save config {config_key}: {e}")
208+
logger.error("Failed to save config %s: %s", config_key, e)
208209

209-
logger.info(f"Autotuning completed in {end_time - start_time:.2f}s")
210+
logger.info("Autotuning completed in %.2fs", end_time - start_time)
210211
logger.info(
211-
f"Generated and saved {len(saved_configs)} configs for {kernel_name}: {saved_configs}"
212+
"Generated and saved %d configs for %s: %s",
213+
len(saved_configs),
214+
kernel_name,
215+
saved_configs,
212216
)
213217

214218
return True
215219

216220
except Exception as e:
217-
logger.error(f"Failed to autotune {kernel_name}: {e}")
221+
logger.error("Failed to autotune %s: %s", kernel_name, e)
218222
return False
219223

220224

@@ -233,7 +237,8 @@ def main():
233237
"--output-dir",
234238
type=str,
235239
default=None,
236-
help="Output directory for config files (default: <vllm_repo>/vllm/compilation/helion/configs)",
240+
help="Output directory for config files "
241+
"(default: <vllm_repo>/vllm/compilation/helion/configs)",
237242
)
238243

239244
parser.add_argument(
@@ -287,9 +292,9 @@ def main():
287292
# Filter to specific kernel if requested
288293
if args.kernel:
289294
if args.kernel not in helion_kernels:
290-
logger.error(f"Kernel '{args.kernel}' not found. Available kernels:")
291-
for name in helion_kernels.keys():
292-
logger.error(f" - {name}")
295+
logger.error("Kernel '%s' not found. Available kernels:", args.kernel)
296+
for name in helion_kernels:
297+
logger.error(" - %s", name)
293298
sys.exit(1)
294299
helion_kernels = {args.kernel: helion_kernels[args.kernel]}
295300

@@ -299,7 +304,7 @@ def main():
299304
# Create output directory
300305
try:
301306
os.makedirs(output_dir, exist_ok=True)
302-
logger.info(f"Output directory: {output_dir}")
307+
logger.info("Output directory: %s", output_dir)
303308

304309
# Verify directory is writable
305310
test_file = os.path.join(output_dir, ".write_test")
@@ -308,31 +313,33 @@ def main():
308313
f.write("test")
309314
os.remove(test_file)
310315
except Exception as e:
311-
logger.error(f"Output directory is not writable: {e}")
316+
logger.error("Output directory is not writable: %s", e)
312317
sys.exit(1)
313318

314319
except Exception as e:
315-
logger.error(f"Failed to create output directory '{output_dir}': {e}")
320+
logger.error("Failed to create output directory '%s': %s", output_dir, e)
316321
sys.exit(1)
317322

318323
# Autotune kernels
319324
total_kernels = len(helion_kernels)
320325
successful = 0
321326

322-
logger.info(f"Starting autotuning for {total_kernels} kernel(s)")
327+
logger.info("Starting autotuning for %d kernel(s)", total_kernels)
323328

324329
for kernel_name, op_cls in helion_kernels.items():
325330
if autotune_kernel(kernel_name, op_cls, output_dir, args.force):
326331
successful += 1
327332
else:
328-
logger.warning(f"Skipped or failed: {kernel_name}")
333+
logger.warning("Skipped or failed: %s", kernel_name)
329334

330335
# Summary
331336
logger.info("=" * 50)
332-
logger.info(f"Autotuning complete: {successful}/{total_kernels} kernels successful")
337+
logger.info(
338+
"Autotuning complete: %d/%d kernels successful", successful, total_kernels
339+
)
333340

334341
if successful < total_kernels:
335-
logger.warning(f"{total_kernels - successful} kernels failed or were skipped")
342+
logger.warning("%d kernels failed or were skipped", total_kernels - successful)
336343
sys.exit(1)
337344
else:
338345
logger.info("All kernels autotuned successfully!")

0 commit comments

Comments
 (0)