Skip to content

Conversation

@LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Aug 23, 2025

WIP; vLLM side of vllm-project/flash-attention#82 merge that first

This PR is just marked ready to validate CI and building before merging vllm-project/flash-attention#82

@mergify mergify bot added the ci/build label Aug 23, 2025
@LucasWilkinson LucasWilkinson added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the flash-attention dependency to a new commit hash, likely to incorporate the 'FA3 swizzle optimization' mentioned in the PR title. While pinning to a commit is good for reproducibility, using a commit hash that is not part of a tag or a long-lived branch can pose a risk for future builds and maintenance. I've added a comment suggesting the use of a git tag for better long-term stability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Pinning dependencies to a specific commit hash is good for reproducibility. However, for long-term maintenance and release builds, it's better to use a git tag. Commit hashes that are not part of a branch or tag can be garbage collected by git, or become hard to track. Since this is a work-in-progress, it's acceptable for now, but it would be best to create a tag in the vllm-project/flash-attention repository for this commit before this PR is merged.

Signed-off-by: Lucas Wilkinson <[email protected]>
@LucasWilkinson LucasWilkinson force-pushed the lwilkinson/fa3-swizzle branch from ed1629a to 7a4e376 Compare August 25, 2025 16:13
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed stale Over 90 days of inactivity v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant