bump rust version from 1.89 to 1.91

Signed-off-by: Connor Tsui <[email protected]>

Author: connortsui20

Cargo.toml

@@ -53,7 +53,7 @@ keywords = ["vortex"]
 license = "Apache-2.0"
 readme = "README.md"
 repository = "https://github.com/spiraldb/vortex"
-rust-version = "1.89"
+rust-version = "1.91"
 version = "0.1.0"
 
 [workspace.dependencies]

bench-vortex/src/bin/compress.rs

@@ -92,7 +92,7 @@ fn compress(
         .map(|f| Target::new(Engine::default(), *f))
         .collect_vec();
 
-    let structlistofints = vec![
+    let structlistofints = [
         StructListOfInts::new(100, 1000, 1),
         StructListOfInts::new(1000, 1000, 1),
         StructListOfInts::new(10000, 1000, 1),

bench-vortex/src/compress/bench.rs

@@ -22,6 +22,7 @@ use {
         bench_run::run_with_setup,
         utils::{convert_utf8view_batch, convert_utf8view_schema},
     },
+    anyhow::Context,
     arrow_array::RecordBatch,
     parking_lot::Mutex,
     std::fs,
@@ -126,9 +127,7 @@ pub fn benchmark_vortex_decompress(
     bench_name: &str,
 ) -> Result<(Duration, CompressionTimingMeasurement)> {
     let mut buf = Vec::new();
-    runtime
-        .block_on(vortex_compress_write(uncompressed, &mut buf))
-        .expect("Failed to compress with vortex for decompression test");
+    runtime.block_on(vortex_compress_write(uncompressed, &mut buf))?;
     let buffer = Bytes::from(buf);
 
     // Run the benchmark and measure time.
@@ -250,7 +249,7 @@ pub fn benchmark_lance_compress(
         .collect::<Result<Vec<_>, _>>()?;
     let converted_schema = convert_utf8view_schema(&schema);
 
-    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
+    let temp_dir = tempfile::tempdir().context("Failed to create temp dir")?;
     let iteration_paths: Arc<Mutex<Vec<PathBuf>>> = Arc::new(Mutex::new(Vec::new()));
     let iteration_counter = AtomicU64::new(0);
 
@@ -284,7 +283,7 @@ pub fn benchmark_lance_compress(
     // Calculate size from the last iteration.
     let paths = iteration_paths.lock();
     let lance_compressed_size_val = if let Some(last_path) = paths.last() {
-        calculate_lance_size(last_path).expect("Failed to calculate Lance size")
+        calculate_lance_size(last_path).context("Failed to calculate Lance size")?
     } else {
         0
     };
@@ -315,7 +314,7 @@ pub fn benchmark_lance_decompress(
     // NOTE: Lance requires filesystem access unlike Parquet/Vortex which use in-memory buffers.
     let chunked = uncompressed.as_::<ChunkedVTable>().clone();
     let (batches, schema) = chunked_to_vec_record_batch(chunked);
-    let temp_dir = tempfile::tempdir().expect("Failed to create temp dir");
+    let temp_dir = tempfile::tempdir().context("Failed to create temp dir")?;
 
     // Write the Lance dataset once for all iterations.
     let dataset_path = runtime.block_on(async {

bench-vortex/src/engines/df/mod.rs

@@ -97,8 +97,7 @@ pub fn make_object_store(
             let s3 = Arc::new(
                 AmazonS3Builder::from_env()
                     .with_bucket_name(bucket_name)
-                    .build()
-                    .unwrap(),
+                    .build()?,
             );
             df.register_object_store(&Url::parse(&format!("s3://{bucket_name}/"))?, s3.clone());
             Ok(s3)
@@ -108,8 +107,7 @@ pub fn make_object_store(
             let gcs = Arc::new(
                 GoogleCloudStorageBuilder::from_env()
                     .with_bucket_name(bucket_name)
-                    .build()
-                    .unwrap(),
+                    .build()?,
             );
             df.register_object_store(&Url::parse(&format!("gs://{bucket_name}/"))?, gcs.clone());
             Ok(gcs)

bench-vortex/src/realnest/gharchive.rs

@@ -119,11 +119,7 @@ impl GithubArchive {
 
 impl Benchmark for GithubArchive {
     fn queries(&self) -> anyhow::Result<Vec<(usize, String)>> {
-        Ok(QUERIES
-            .iter()
-            .map(|s| (s.to_string()))
-            .enumerate()
-            .collect())
+        Ok(QUERIES.iter().map(|s| s.to_string()).enumerate().collect())
     }
 
     fn generate_data(&self, target: &Target) -> anyhow::Result<()> {

encodings/fastlanes/benches/bitpacking_take.rs

@@ -238,7 +238,7 @@ fn patched_take_10k_adversarial(bencher: Bencher) {
         (0..(NUM_EXCEPTIONS + 1024) / 1024)
             .cycle()
             .map(|chunk_idx| BIG_BASE2 - 1024 + chunk_idx * 1024)
-            .flat_map(|base_idx| (base_idx..(base_idx + per_chunk_count)))
+            .flat_map(|base_idx| base_idx..(base_idx + per_chunk_count))
             .take(10000),
     );
 

encodings/fastlanes/src/delta/array/mod.rs

@@ -122,7 +122,7 @@ impl DeltaArray {
 
         let lanes = lane_count(ptype);
 
-        if (deltas.len() % 1024 == 0) != (bases.len() % lanes == 0) {
+        if deltas.len().is_multiple_of(1024) != bases.len().is_multiple_of(lanes) {
             vortex_bail!(
                 "deltas length ({}) is a multiple of 1024 iff bases length ({}) is a multiple of LANES ({})",
                 deltas.len(),

rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.89"
+channel = "1.91"
 components = ["rust-src", "rustfmt", "clippy", "rust-analyzer"]
 profile = "minimal"

vortex-array/benches/chunk_array_builder.rs

@@ -116,7 +116,7 @@ fn make_opt_bool_chunks(len: usize, chunk_count: usize) -> ArrayRef {
     let mut rng = StdRng::seed_from_u64(0);
 
     const SPAN_LEN: usize = 10;
-    assert!(len % SPAN_LEN == 0);
+    assert!(len.is_multiple_of(SPAN_LEN));
 
     (0..chunk_count)
         .map(|_| {

vortex-array/benches/varbinview_zip.rs

@@ -78,5 +78,5 @@ fn alternating_mask(len: usize) -> Mask {
 }
 
 fn block_mask(len: usize, block: usize) -> Mask {
-    Mask::from_iter((0..len).map(|i| (i / block) % 2 == 0))
+    Mask::from_iter((0..len).map(|i| (i / block).is_multiple_of(2)))
 }