fix benchmark hygiene

Signed-off-by: Connor Tsui <[email protected]>

Author: connortsui20

vortex-compute/benches/avx512.rs

@@ -46,42 +46,44 @@ const SAMPLE_SIZE: u32 = 64;
 
 #[divan::bench(sample_size = SAMPLE_SIZE, args = SIZES.iter().copied().cartesian_product(PROBABILITIES.iter().copied()))]
 fn in_place_scalar(bencher: divan::Bencher, (size, probability): (usize, f64)) {
-    let mask = create_random_mask(size, probability);
+    let mask = divan::black_box(create_random_mask(size, probability));
+    let data = (0..size as i32).collect::<Vec<_>>();
     bencher
-        .with_inputs(|| (0..size as i32).collect::<Vec<_>>())
-        .bench_refs(|data| filter_in_place_scalar(data, &mask))
+        .with_inputs(|| (data.clone(), &mask))
+        .bench_refs(|(data, mask)| filter_in_place_scalar(data, mask))
 }
 
 #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
 #[divan::bench(sample_size = SAMPLE_SIZE, args = SIZES.iter().copied().cartesian_product(PROBABILITIES.iter().copied()))]
 fn in_place_avx512(bencher: divan::Bencher, (size, probability): (usize, f64)) {
-    let mask = create_random_mask(size, probability);
+    let mask = divan::black_box(create_random_mask(size, probability));
+    let data = (0..size as i32).collect::<Vec<_>>();
     bencher
-        .with_inputs(|| (0..size as i32).collect::<Vec<_>>())
-        .bench_refs(|data| unsafe { filter_in_place_avx512(data, &mask) })
+        .with_inputs(|| (data.clone(), &mask))
+        .bench_refs(|(data, mask)| filter_in_place_avx512(data, mask))
 }
 
 #[divan::bench(sample_size = SAMPLE_SIZE, args = SIZES.iter().copied().cartesian_product(PROBABILITIES.iter().copied()))]
 fn out_scalar(bencher: divan::Bencher, (size, probability): (usize, f64)) {
-    let mask = create_random_mask(size, probability);
+    let mask = divan::black_box(create_random_mask(size, probability));
+    let src = (0..size as i32).collect::<Vec<_>>();
     bencher
         .with_inputs(|| {
-            let src = (0..size as i32).collect::<Vec<_>>();
             let dest = vec![0i32; size];
-            (src, dest)
+            (src.clone(), dest, &mask)
         })
-        .bench_refs(|(src, dest)| filter_into_scalar(src, dest, &mask))
+        .bench_refs(|(src, dest, mask)| filter_into_scalar(src, dest, mask))
 }
 
 #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
 #[divan::bench(sample_size = SAMPLE_SIZE, args = SIZES.iter().copied().cartesian_product(PROBABILITIES.iter().copied()))]
 fn out_avx512(bencher: divan::Bencher, (size, probability): (usize, f64)) {
-    let mask = create_random_mask(size, probability);
+    let mask = divan::black_box(create_random_mask(size, probability));
+    let src = (0..size as i32).collect::<Vec<_>>();
     bencher
         .with_inputs(|| {
-            let src = (0..size as i32).collect::<Vec<_>>();
             let dest = vec![0i32; size];
-            (src, dest)
+            (src.clone(), dest, &mask)
         })
-        .bench_refs(|(src, dest)| unsafe { filter_into_avx512(src, dest, &mask) })
+        .bench_refs(|(src, dest, mask)| unsafe { filter_into_avx512(src, dest, mask) })
 }