-
Notifications
You must be signed in to change notification settings - Fork 101
Feature: add take for primitive and bool vectors
#5540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
910470a to
30a1227
Compare
take for bitbuffer, mask, primitive vector
CodSpeed Performance ReportMerging #5540 will not alter performanceComparing Summary
Footnotes
|
f3ac42e to
3e430bf
Compare
f3d3dde to
eea184b
Compare
take for bitbuffer, mask, primitive vectortake for primitive and bool vectors
bd6549c to
dfa2f74
Compare
12379a7 to
ae63951
Compare
dfa2f74 to
70bf932
Compare
ae63951 to
94a3f87
Compare
70bf932 to
fc55e05
Compare
94a3f87 to
15f1d43
Compare
fc55e05 to
e7e0ef2
Compare
15f1d43 to
0531061
Compare
e7e0ef2 to
8b07ace
Compare
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
0531061 to
bb75272
Compare
Signed-off-by: Connor Tsui <[email protected]>
bb75272 to
9583f20
Compare
Adds
takeimplementations and tests for:BitBufferMaskBoolVectorPrimitiveVectorFor
BitBuffer, I don't think it makes sense to implement take with nullable indices since I would argue that there isn't a clear behavior to have (because it might not be obvious thattruemeans not null andfalsemeans null). But forMaskit feels a bit different, we are using it for validity in all of our vectors, so I think it makes a bit more sense (and it will make the implementation oftakefor the rest of the vectors easier).We represent indices in 3 different ways here (a generic indices slice of unsigned integers, generic unsigned pvector, and primitive vector). I feel quite strongly that we should not allow signed indices, as that opens the door to too many bugs. See this Slack thread.
This is also based on top of #5537, so that needs to merge first.