Address review: remove 'cmp' variable

vstinner · vstinner · commit 8592ef1fa625 · 2024-10-08T15:18:04.000+02:00
diff --git a/Objects/stringlib/eq.h b/Objects/stringlib/eq.h
@@ -18,6 +18,5 @@ unicode_eq(PyObject *str1, PyObject *str2)
 
     const void *data1 = PyUnicode_DATA(str1);
     const void *data2 = PyUnicode_DATA(str2);
-    int cmp = memcmp(data1, data2, len * kind);
-    return (cmp == 0);
+    return (memcmp(data1, data2, len * kind) == 0);
 }
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -10983,8 +10983,7 @@ unicode_compare_eq(PyObject *str1, PyObject *str2)
 
     const void *data1 = PyUnicode_DATA(str1);
     const void *data2 = PyUnicode_DATA(str2);
-    int cmp = memcmp(data1, data2, len * kind);
-    return (cmp == 0);
+    return (memcmp(data1, data2, len * kind) == 0);
 }
 
 int

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,5 @@ unicode_eq(PyObject str1, PyObject str2)`
`18`	`18`
`19`	`19`	`const void *data1 = PyUnicode_DATA(str1);`
`20`	`20`	`const void *data2 = PyUnicode_DATA(str2);`
`21`		`- int cmp = memcmp(data1, data2, len * kind);`
`22`		`- return (cmp == 0);`
	`21`	`+ return (memcmp(data1, data2, len * kind) == 0);`
`23`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10983,8 +10983,7 @@ unicode_compare_eq(PyObject str1, PyObject str2)`
`10983`	`10983`
`10984`	`10984`	`const void *data1 = PyUnicode_DATA(str1);`
`10985`	`10985`	`const void *data2 = PyUnicode_DATA(str2);`
`10986`		`- int cmp = memcmp(data1, data2, len * kind);`
`10987`		`- return (cmp == 0);`
	`10986`	`+ return (memcmp(data1, data2, len * kind) == 0);`
`10988`	`10987`	`}`
`10989`	`10988`
`10990`	`10989`	`int`