refactor(typescript-plugin): getPropertiesAtLocation -> isRefAtLocation

Author: johnsoncodehk

packages/language-server/index.ts

@@ -129,8 +129,8 @@ connection.onInitialize(params => {
 			getImportPathForFile(...args) {
 				return sendTsServerRequest('_vue:getImportPathForFile', args);
 			},
-			getPropertiesAtLocation(...args) {
-				return sendTsServerRequest('_vue:getPropertiesAtLocation', args);
+			isRefAtLocation(...args) {
+				return sendTsServerRequest('_vue:isRefAtLocation', args);
 			},
 			getDocumentHighlights(fileName, position) {
 				return sendTsServerRequest(

packages/language-service/lib/plugins/vue-autoinsert-dotvalue.ts

@@ -5,7 +5,7 @@ import { resolveEmbeddedCode } from '../utils';
 
 export function create(
 	ts: typeof import('typescript'),
-	{ getPropertiesAtLocation }: import('@vue/typescript-plugin/lib/requests').Requests,
+	{ isRefAtLocation }: import('@vue/typescript-plugin/lib/requests').Requests,
 ): LanguageServicePlugin {
 	return {
 		name: 'vue-autoinsert-dotvalue',
@@ -60,8 +60,7 @@ export function create(
 						}
 					}
 
-					const props = await getPropertiesAtLocation(info.root.fileName, sourceOffset) ?? [];
-					if (props.some(prop => prop === 'value')) {
+					if (await isRefAtLocation(info.root.fileName, sourceOffset)) {
 						return '${1:.value}';
 					}
 				},

packages/typescript-plugin/index.ts

@@ -12,7 +12,7 @@ import { getComponentSlots } from './lib/requests/getComponentSlots';
 import { getElementAttrs } from './lib/requests/getElementAttrs';
 import { getElementNames } from './lib/requests/getElementNames';
 import { getImportPathForFile } from './lib/requests/getImportPathForFile';
-import { getPropertiesAtLocation } from './lib/requests/getPropertiesAtLocation';
+import { isRefAtLocation } from './lib/requests/isRefAtLocation';
 
 const windowsPathReg = /\\/g;
 const project2Service = new WeakMap<
@@ -116,11 +116,11 @@ export = createLanguageServicePlugin(
 					response: getImportPathForFile(ts, languageServiceHost, program, fileName, incomingFileName, preferences),
 				};
 			});
-			session.addProtocolHandler('_vue:getPropertiesAtLocation', request => {
-				const [fileName, position]: Parameters<Requests['getPropertiesAtLocation']> = request.arguments;
+			session.addProtocolHandler('_vue:isRefAtLocation', request => {
+				const [fileName, position]: Parameters<Requests['isRefAtLocation']> = request.arguments;
 				const { language, program, sourceScript, virtualCode } = getLanguageServiceAndVirtualCode(fileName);
 				return {
-					response: getPropertiesAtLocation(ts, language, program, sourceScript, virtualCode, position, true),
+					response: isRefAtLocation(ts, language, program, sourceScript, virtualCode, position, true),
 				};
 			});
 			session.addProtocolHandler('_vue:getComponentDirectives', request => {

packages/typescript-plugin/lib/requests/index.ts

@@ -12,11 +12,11 @@ export interface Requests {
 		incomingFileName: string,
 		preferences: ts.UserPreferences,
 	): Response<ReturnType<typeof import('./getImportPathForFile.js')['getImportPathForFile']>>;
-	getPropertiesAtLocation(
+	isRefAtLocation(
 		fileName: string,
 		position: number,
 	): Response<
-		ReturnType<typeof import('./getPropertiesAtLocation.js')['getPropertiesAtLocation']>
+		ReturnType<typeof import('./isRefAtLocation.js')['isRefAtLocation']>
 	>;
 	getComponentDirectives(fileName: string): Response<
 		ReturnType<typeof import('./getComponentDirectives.js')['getComponentDirectives']>

packages/typescript-plugin/lib/requests/getPropertiesAtLocation.ts renamed to packages/typescript-plugin/lib/requests/isRefAtLocation.ts

@@ -3,22 +3,22 @@
 import { isCompletionEnabled, type Language, type SourceScript, type VueVirtualCode } from '@vue/language-core';
 import type * as ts from 'typescript';
 
-export function getPropertiesAtLocation(
+export function isRefAtLocation(
 	ts: typeof import('typescript'),
 	language: Language,
 	program: ts.Program,
 	sourceScript: SourceScript,
 	virtualCode: VueVirtualCode,
 	position: number,
 	isTsPlugin: boolean,
-): string[] {
-	const virtualScript = sourceScript.generated!.languagePlugin.typescript?.getServiceScript(virtualCode);
-	if (!virtualScript) {
-		return [];
+): boolean {
+	const serviceScript = sourceScript.generated!.languagePlugin.typescript?.getServiceScript(virtualCode);
+	if (!serviceScript) {
+		return false;
 	}
 
 	let mapped = false;
-	for (const [_sourceScript, map] of language.maps.forEach(virtualScript.code)) {
+	for (const [_sourceScript, map] of language.maps.forEach(serviceScript.code)) {
 		for (const [position2, mapping] of map.toGeneratedLocation(position)) {
 			if (isCompletionEnabled(mapping.data)) {
 				position = position2;
@@ -31,25 +31,25 @@ export function getPropertiesAtLocation(
 		}
 	}
 	if (!mapped) {
-		return [];
+		return false;
 	}
 	position += isTsPlugin ? sourceScript.snapshot.getLength() : 0;
 
 	const sourceFile = program.getSourceFile(virtualCode.fileName);
 	if (!sourceFile) {
-		return [];
+		return false;
 	}
 
 	const node = findPositionIdentifier(sourceFile, sourceFile, position);
 	if (!node) {
-		return [];
+		return false;
 	}
 
 	const checker = program.getTypeChecker();
 	const type = checker.getTypeAtLocation(node);
 	const props = type.getProperties();
 
-	return props.map(prop => prop.name);
+	return props.some(prop => prop.name === 'value');
 
 	function findPositionIdentifier(sourceFile: ts.SourceFile, node: ts.Node, offset: number) {
 		let result: ts.Node | undefined;