Skip to content

Commit ca0f9a4

Browse files
committed
refactor: remove unnecessary isGlobal
1 parent 35baa6e commit ca0f9a4

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

packages/language-service/lib/plugins/vue-template.ts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ export function create(
241241
prop = {
242242
name,
243243
kind: 'prop',
244-
isGlobal: true,
245244
};
246245
}
247246
}
@@ -252,7 +251,7 @@ export function create(
252251
const { isEvent, propName } = getPropName(prop.name, prop.kind === 'event');
253252

254253
if (prop.kind === 'prop') {
255-
if (!prop.isGlobal || specialProps.has(propName)) {
254+
if (!prop.isGlobal) {
256255
item.kind = 5 satisfies typeof CompletionItemKind.Field;
257256
}
258257
}
@@ -263,7 +262,7 @@ export function create(
263262
}
264263
}
265264

266-
if (!prop.isGlobal || specialProps.has(propName)) {
265+
if (!prop.isGlobal) {
267266
tokens.push('\u0000');
268267

269268
if (item.label.startsWith(':')) {
@@ -576,7 +575,7 @@ export function create(
576575
});
577576
}
578577

579-
const models: [boolean, string][] = [];
578+
const models: string[] = [];
580579

581580
for (
582581
const prop of [
@@ -585,31 +584,28 @@ export function create(
585584
]
586585
) {
587586
if (prop.name.startsWith('onUpdate:')) {
588-
const isGlobal = !propNameSet.has(prop.name);
589-
models.push([isGlobal, prop.name.slice('onUpdate:'.length)]);
587+
models.push(prop.name.slice('onUpdate:'.length));
590588
}
591589
}
592590
for (const event of events) {
593591
if (event.startsWith('update:')) {
594-
models.push([false, event.slice('update:'.length)]);
592+
models.push(event.slice('update:'.length));
595593
}
596594
}
597595

598-
for (const [isGlobal, model] of models) {
596+
for (const model of models) {
599597
const name = casing.attr === AttrNameCasing.Camel ? model : hyphenateAttr(model);
600598

601599
attributes.push({ name: 'v-model:' + name });
602600
propMap.set('v-model:' + name, {
603601
name,
604602
kind: 'prop',
605-
isGlobal,
606603
});
607604

608605
if (model === 'modelValue') {
609606
propMap.set('v-model', {
610607
name,
611608
kind: 'prop',
612-
isGlobal,
613609
});
614610
}
615611
}

0 commit comments

Comments
 (0)