test(ast-utils): add comprehensive unit tests for utility functions

- Add unit tests for isDefineStoreCall, getStoreId, extractDeclarations, and extractReturnProperties
- Ensure support for optional chaining, template literals, and nested structures in AST utilities
- Improve test coverage to handle edge cases and various argument forms

Author: doubledare704

packages/eslint-plugin/package.json

@@ -28,14 +28,15 @@
   "sideEffects": false,
   "exports": {
     "types": "./dist/index.d.ts",
-    "require": "./dist/index.js",
+    "require": "./dist/index.cjs",
     "import": "./dist/index.mjs"
   },
-  "main": "./dist/index.js",
+  "main": "./dist/index.cjs",
   "module": "./dist/index.mjs",
   "types": "./dist/index.d.ts",
   "files": [
     "dist/*.js",
+    "dist/*.cjs",
     "dist/*.mjs",
     "dist/*.d.ts",
     "dist/*.d.mts",
@@ -61,7 +62,7 @@
     "node": ">=18.18.0"
   },
   "peerDependencies": {
-    "eslint": ">=8.0.0"
+    "eslint": ">=8.57.0 || ^9.0.0"
   },
   "publishConfig": {
     "access": "public"

packages/eslint-plugin/src/utils/__tests__/ast-utils.test.ts

@@ -0,0 +1,225 @@
+/**
+ * @fileoverview Tests for AST utilities
+ */
+
+import { describe, it, expect } from 'vitest'
+import { parseForESLint } from '@typescript-eslint/parser'
+import type { TSESTree } from '@typescript-eslint/utils'
+import {
+  isDefineStoreCall,
+  getStoreId,
+  extractDeclarations,
+  extractReturnProperties,
+} from '../ast-utils'
+
+function parseCode(code: string): TSESTree.Program {
+  const result = parseForESLint(code, {
+    ecmaVersion: 2020,
+    sourceType: 'module',
+  })
+  return result.ast
+}
+
+function findCallExpression(ast: TSESTree.Program): TSESTree.CallExpression {
+  let callExpression: TSESTree.CallExpression | null = null
+
+  function traverse(node: any): void {
+    if (node.type === 'CallExpression') {
+      callExpression = node
+      return
+    }
+    for (const key in node) {
+      if (node[key] && typeof node[key] === 'object') {
+        if (Array.isArray(node[key])) {
+          node[key].forEach(traverse)
+        } else {
+          traverse(node[key])
+        }
+      }
+    }
+  }
+
+  traverse(ast)
+  return callExpression!
+}
+
+describe('isDefineStoreCall', () => {
+  it('should detect direct defineStore calls', () => {
+    const code = 'defineStore("test", () => {})'
+    const ast = parseCode(code)
+    const callExpr = findCallExpression(ast)
+    expect(isDefineStoreCall(callExpr)).toBe(true)
+  })
+
+  it('should detect member expression defineStore calls', () => {
+    const code = 'pinia.defineStore("test", () => {})'
+    const ast = parseCode(code)
+    const callExpr = findCallExpression(ast)
+    expect(isDefineStoreCall(callExpr)).toBe(true)
+  })
+
+  it('should detect optional chaining defineStore calls', () => {
+    const code = 'pinia?.defineStore("test", () => {})'
+    const ast = parseCode(code)
+    const callExpr = findCallExpression(ast)
+    expect(isDefineStoreCall(callExpr)).toBe(true)
+  })
+
+  it('should not detect non-defineStore calls', () => {
+    const code = 'someOtherFunction("test", () => {})'
+    const ast = parseCode(code)
+    const callExpr = findCallExpression(ast)
+    expect(isDefineStoreCall(callExpr)).toBe(false)
+  })
+})
+
+describe('getStoreId', () => {
+  it('should extract string literal IDs', () => {
+    const code = 'defineStore("user", () => {})'
+    const ast = parseCode(code)
+    const callExpr = findCallExpression(ast)
+    expect(getStoreId(callExpr)).toBe('user')
+  })
+
+  it('should extract template literal IDs without interpolations', () => {
+    const code = 'defineStore(`user`, () => {})'
+    const ast = parseCode(code)
+    const callExpr = findCallExpression(ast)
+    expect(getStoreId(callExpr)).toBe('user')
+  })
+
+  it('should extract IDs from object expressions with string literals', () => {
+    const code = 'defineStore({ id: "user" }, () => {})'
+    const ast = parseCode(code)
+    const callExpr = findCallExpression(ast)
+    expect(getStoreId(callExpr)).toBe('user')
+  })
+
+  it('should extract IDs from object expressions with template literals', () => {
+    const code = 'defineStore({ id: `user` }, () => {})'
+    const ast = parseCode(code)
+    const callExpr = findCallExpression(ast)
+    expect(getStoreId(callExpr)).toBe('user')
+  })
+
+  it('should return null for template literals with interpolations', () => {
+    const code = 'defineStore(`user-${suffix}`, () => {})'
+    const ast = parseCode(code)
+    const callExpr = findCallExpression(ast)
+    expect(getStoreId(callExpr)).toBe(null)
+  })
+})
+
+describe('extractDeclarations', () => {
+  it('should extract variable declarations and deduplicate', () => {
+    const code = `
+      function setup() {
+        const name = ref('test')
+        let count = 0
+        const name = ref('duplicate') // This should be deduplicated
+        return { name, count }
+      }
+    `
+    const ast = parseCode(code)
+    const func = ast.body[0] as TSESTree.FunctionDeclaration
+    const result = extractDeclarations(func.body!)
+
+    expect(result.variables).toEqual(['name', 'count'])
+  })
+
+  it('should extract loop initializer declarations', () => {
+    const code = `
+      function setup() {
+        for (let i = 0; i < 10; i++) {
+          console.log(i)
+        }
+        for (const item of items) {
+          console.log(item)
+        }
+        return {}
+      }
+    `
+    const ast = parseCode(code)
+    const func = ast.body[0] as TSESTree.FunctionDeclaration
+    const result = extractDeclarations(func.body!)
+
+    expect(result.variables).toContain('i')
+    expect(result.variables).toContain('item')
+  })
+
+  it('should extract catch clause parameters', () => {
+    const code = `
+      function setup() {
+        try {
+          doSomething()
+        } catch (error) {
+          console.log(error)
+        }
+        return {}
+      }
+    `
+    const ast = parseCode(code)
+    const func = ast.body[0] as TSESTree.FunctionDeclaration
+    const result = extractDeclarations(func.body!)
+
+    expect(result.variables).toContain('error')
+  })
+})
+
+describe('extractReturnProperties', () => {
+  it('should extract identifier property keys', () => {
+    const code = `
+      function setup() {
+        return { name, count, total }
+      }
+    `
+    const ast = parseCode(code)
+    const func = ast.body[0] as TSESTree.FunctionDeclaration
+    const returnStmt = func.body!.body[0] as TSESTree.ReturnStatement
+    const result = extractReturnProperties(returnStmt)
+
+    expect(result).toEqual(['name', 'count', 'total'])
+  })
+
+  it('should extract quoted string property keys', () => {
+    const code = `
+      function setup() {
+        return { "name": value, 'count': value2 }
+      }
+    `
+    const ast = parseCode(code)
+    const func = ast.body[0] as TSESTree.FunctionDeclaration
+    const returnStmt = func.body!.body[0] as TSESTree.ReturnStatement
+    const result = extractReturnProperties(returnStmt)
+
+    expect(result).toEqual(['name', 'count'])
+  })
+
+  it('should extract template literal property keys without interpolations', () => {
+    const code = `
+      function setup() {
+        return { [\`name\`]: value, [\`count\`]: value2 }
+      }
+    `
+    const ast = parseCode(code)
+    const func = ast.body[0] as TSESTree.FunctionDeclaration
+    const returnStmt = func.body!.body[0] as TSESTree.ReturnStatement
+    const result = extractReturnProperties(returnStmt)
+
+    expect(result).toEqual(['name', 'count'])
+  })
+
+  it('should handle MemberExpression returns', () => {
+    const code = `
+      function setup() {
+        return someObject.property
+      }
+    `
+    const ast = parseCode(code)
+    const func = ast.body[0] as TSESTree.FunctionDeclaration
+    const returnStmt = func.body!.body[0] as TSESTree.ReturnStatement
+    const result = extractReturnProperties(returnStmt)
+
+    expect(result).toEqual([])
+  })
+})