fix: hmr not working for watched files in path loaders

brc-dd · brc-dd · commit e271695d7162 · 2025-02-27T15:11:08.000+05:30
follow up on #4525
diff --git a/src/node/plugin.ts b/src/node/plugin.ts
@@ -307,7 +307,8 @@ export async function createVitePressPlugin(
           if (url?.endsWith('.html')) {
             res.statusCode = 200
             res.setHeader('Content-Type', 'text/html')
-            let html = `<!DOCTYPE html>
+            let html = `\
+<!DOCTYPE html>
 <html>
   <head>
     <title></title>
diff --git a/src/node/plugins/dynamicRoutesPlugin.ts b/src/node/plugins/dynamicRoutesPlugin.ts
@@ -187,10 +187,17 @@ export const dynamicRoutesPlugin = async (
 
       // Also check if the file matches any custom watch patterns.
       let watchedFileChanged = false
-      for (const [, route] of routeModuleCache) {
+      for (const [file, route] of routeModuleCache) {
         if (route.watch && isMatch(normalizedFile, route.watch)) {
           route.routes = undefined
           watchedFileChanged = true
+
+          for (const id of moduleGraph.delete(file)) {
+            const mod = this.environment.moduleGraph.getModuleById(id)
+            if (mod) {
+              modules.push(mod)
+            }
+          }
         }
       }
 
diff --git a/src/node/plugins/staticDataPlugin.ts b/src/node/plugins/staticDataPlugin.ts
@@ -150,7 +150,7 @@ export const staticDataPlugin: Plugin = {
       const loader = idToLoaderModulesMap[id]
       if (loader && loader.watch && isMatch(normalizedFile, loader.watch)) {
         const mod = this.environment.moduleGraph.getModuleById(id)
-        if (mod && !modules.includes(mod)) {
+        if (mod) {
           modules.push(mod)
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ export const staticDataPlugin: Plugin = {`
`150`	`150`	`const loader = idToLoaderModulesMap[id]`
`151`	`151`	`if (loader && loader.watch && isMatch(normalizedFile, loader.watch)) {`
`152`	`152`	`const mod = this.environment.moduleGraph.getModuleById(id)`
`153`		`- if (mod && !modules.includes(mod)) {`
	`153`	`+ if (mod) {`
`154`	`154`	`modules.push(mod)`
`155`	`155`	`}`
`156`	`156`	`}`