fix: $isPersisted

Author: phortx

src/orm/model.ts

@@ -105,20 +105,18 @@ export default class Model {
   }
 
   /**
-   * Adds $isPersisted and other meta fields to the model by overwriting the fields() method.
-   * @todo is this a good way to add fields?
+   * Adds $isPersisted and other meta fields to the model.
+   *
+   * TODO: This feels rather hacky currently and may break anytime the internal structure of
+   * the core changes. Maybe in the future there will be a feature in the core that allows to add
+   * those meta fields by plugins.
    * @param {Model} model
    */
   public static augment(model: Model) {
-    const originalFieldGenerator = model.baseModel.fields.bind(model.baseModel);
-
-    model.baseModel.fields = () => {
-      const originalFields = originalFieldGenerator();
-
-      originalFields["$isPersisted"] = model.baseModel.boolean(false);
+    let baseModel: typeof PatchedModel = model.baseModel;
 
-      return originalFields;
-    };
+    baseModel.getFields();
+    baseModel.cachedFields[baseModel.entity]["$isPersisted"] = baseModel.boolean(false);
   }
 
   /**

test/integration/plugin.spec.ts

@@ -57,21 +57,17 @@ describe("Plugin GraphQL", () => {
 
     test("is true for single fetched records", async () => {
       // @ts-ignore
-      await User.fetch(1);
+      await Post.fetch(1);
 
-      let user: Data = User.find(1)! as Data;
-      expect(user.$isPersisted).toBeTruthy();
+      let post: Data = Post.query().first()! as Data;
+      expect(post.$isPersisted).toBeTruthy();
     });
 
     test("is true for multiple fetched records", async () => {
-      await User.fetch();
-      await Tariff.fetch();
-
-      let user: Data = User.query().first()! as Data;
-      expect(user.$isPersisted).toBeTruthy();
+      await Post.fetch();
 
-      let tariff: Data = Tariff.query().first()! as Data;
-      expect(tariff.$isPersisted).toBeTruthy();
+      let post: Data = Post.query().first()! as Data;
+      expect(post.$isPersisted).toBeTruthy();
     });
   });
 });

test/support/helpers.ts

@@ -42,7 +42,8 @@ export function createStore(entities: Array<Entity>, headers?: any, adapter?: Ad
     database: database,
     link,
     headers,
-    adapter
+    adapter,
+    debug: false
   });
 
   const store = new Vuex.Store({