Skip to content

parse_args assumes calldata location for type_from_annotation call #4754

@cyberthirst

Description

@cyberthirst

Version Information

  • vyper Version (output of vyper --version): 34a9e08

What's your issue about?

the following assumes call the calldata location

type_ = type_from_annotation(arg.annotation, DataLocation.CALLDATA)

this doesn't have to be the case for e.g. internal functions

as such, the following check can be imprecise:

if location in typ._invalid_locations:

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions