Skip to content

Commit a5d6a11

Browse files
authored
Merge pull request #143 from w3bdesign/development
Fix prosjekt images
2 parents a203df6 + 97a03e1 commit a5d6a11

File tree

2 files changed

+12
-18
lines changed

2 files changed

+12
-18
lines changed

README.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ Fourth version of my personal portfolio website with Next.js, Framer Motion, San
2929

3030
### General
3131

32+
- Clean, modern, responsive and Matrix-inspired design
33+
- Matrix canvas rain effect on front page
3234
- Next.js 14 with Typescript and App router
3335
- Sanity.io for fetching project information and frontpage text
3436
- Ladle for component documentation
@@ -46,14 +48,12 @@ Fourth version of my personal portfolio website with Next.js, Framer Motion, San
4648
- Fully responsive design tested on all devices
4749
- React Icons for project icons
4850
- Tailwind CSS for styling
49-
- Google fonts with Lato (optimized with @next/font for Next.js)
5051
- Animated reusable input fields
5152

5253
### Accessibility
5354

5455
- WCAG accessibility tested
5556
- Accessibility testing with Cypress Axe
56-
- Accessibility testing with Axe in Storybook for each component
5757

5858
### Devops / Code quality
5959

@@ -64,8 +64,4 @@ Fourth version of my personal portfolio website with Next.js, Framer Motion, San
6464
- E2E testing with Playwright integrated with Github actions
6565
- Unit testing with Jest and React Testing Library integrated with CircleCI
6666
- Test coverage setup with Codecov
67-
- 97% test coverage with Jest and React testing library
68-
69-
## TODO
70-
71-
- React Hook Form
67+
- 97% test coverage with Jest and React testing library

src/components/Prosjekter/ProsjektCard.component.tsx

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,11 @@ const ProsjektCard: React.FC<ProjectProps> = ({
2626
<div className="bg-slate-700 shadow-md rounded-lg overflow-hidden mx-4 md:m-0">
2727
<BounceInScroll viewAmount={0.3}>
2828
<div className="relative w-full h-48 md:h-60">
29-
<div className="w-full h-full p-5 md:pb-[50px] relative overflow-hidden flex justify-center md:w-[750px] md:h-[350px]">
29+
<div className="w-full h-full p-5 md:pb-[20px] relative overflow-hidden flex justify-center md:h-[340px]">
3030
{projectimage && (
3131
<Image
32-
className="flex justify-center text-center"
3332
width="600"
34-
height="350"
33+
height="340"
3534
quality={100}
3635
src={urlFor(projectimage).url() as string}
3736
alt={name}
@@ -41,14 +40,13 @@ const ProsjektCard: React.FC<ProjectProps> = ({
4140
)}
4241
</div>
4342
</div>
44-
<div className="md:mt-12 p-2 flex flex-col justify-between min-h-[250px] xl:min-h-[275px]">
45-
<div>
46-
<h1 className="xl:mt-4 text-xl text-center font-bold py-2 text-slate-200">
47-
{name}
48-
</h1>
49-
<h2 className="text-md">{description}</h2>
50-
<p className="mt-4 text-sm mt-2">{subdescription}</p>
51-
</div>
43+
<div className="md:mt-16 p-2 flex flex-col justify-between min-h-[250px] xl:min-h-[275px]">
44+
<h1 className="xl:mt-4 text-xl text-center font-bold py-2 text-slate-200">
45+
{name}
46+
</h1>
47+
<h2 className="text-md">{description}</h2>
48+
<p className="mt-4 text-sm mt-2">{subdescription}</p>
49+
5250
<div className="flex justify-center mt-4">
5351
{urlwww && urlwww.length > 0 && (
5452
<Button href={urlwww[0].url} renderAs="a">

0 commit comments

Comments
 (0)