fix: improve workflow dependencies and helm chart publishing (#212)

- Make build depend on test completion (sequential flow)
- Remove build-docs dependency from release job
- Add missing IMG and CHART_REGISTRY environment variables for helm publishing
- Ensure helm charts are properly pushed to ghcr.io/weaveworks/charts

Author: casibbald

.github/workflows/ci.yaml

@@ -7,9 +7,6 @@ on:
   pull_request:
     branches:
       - main
-  pull_request_target:
-    types:
-      - closed
   workflow_dispatch:
 
 env:
@@ -88,6 +85,7 @@ jobs:
 
   build:
     runs-on: ubuntu-latest
+    needs: [test]
     permissions:
       contents: read # for actions/checkout to fetch code
       packages: write # for pushing to ghcr.io
@@ -138,7 +136,7 @@ jobs:
 
   release:
     runs-on: ubuntu-latest
-    needs: [build, test, build-docs, release-please]
+    needs: [build, test, release-please]
     # only run when release-please creates a release
     if: needs.release-please.outputs.release_created == 'true'
     permissions:
@@ -177,12 +175,15 @@ jobs:
           make publish-helm-chart
         env:
           VERSION: ${{ steps.get_version.outputs.VERSION }}
+          IMG: ghcr.io/weaveworks/gitopssets-controller:${{ steps.get_version.outputs.VERSION }}
+          CHART_REGISTRY: ghcr.io/weaveworks/charts
 
       - name: Generate release manifests
         run: |
           make release
         env:
           VERSION: ${{ steps.get_version.outputs.VERSION }}
+          IMG: ghcr.io/weaveworks/gitopssets-controller:${{ steps.get_version.outputs.VERSION }}
 
       - name: Upload release artifacts
         uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # v2.0.8