Fix the event type for error cases.

There's no Error type, the event types are corev1.EventTypeNormal and
corev1.EventTypeWarning.

This was manifesting in the logs as an error saying that Error event
types weren't supported.

Author: bigkevmcd

controllers/gitopsset_controller.go

@@ -76,9 +76,9 @@ func (r *GitOpsSetReconciler) event(obj *templatesv1.GitOpsSet, severity, msg st
 		reason = severity
 	}
 
-	eventType := "Normal"
+	eventType := corev1.EventTypeNormal
 	if severity == eventv1.EventSeverityError {
-		eventType = "Error"
+		eventType = corev1.EventTypeWarning
 	}
 
 	r.EventRecorder.Event(obj, eventType, reason, msg)

tests/e2e/gitopsset_controller_test.go

@@ -1028,7 +1028,7 @@ func TestEventsWithFailingReconciling(t *testing.T) {
 		// reconciliation should fail because there is an existing resource.
 		want := []*test.EventData{
 			{
-				EventType: "Error",
+				EventType: corev1.EventTypeWarning,
 				Reason:    "ReconciliationFailed",
 			},
 		}