-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Description
Based on comments in the following PR, it was noted that there is a slight inconsistency between how object status messages are computed from object conditions in Explorer and in the non-Explorer frontend.
In Explorer, we usually return a message from the object's Ready condition, and if no Ready condition is available, then an empty string:
| func defaultFluxObjectMessageFunc(obj client.Object) string { |
In the non-Explorer frontend we also try to return a message from a Ready condition first, but if no Ready condition is available, we might return messages from a False condition or the messages from the first of object's conditions:
https://github.com/weaveworks/weave-gitops/blob/cc3c17632334ffa56838c4765e68ce388bde6b2f/ui/components/KubeStatusIndicator.tsx#L64
AC
- define which way of computing object status messages is preferred.
- implemented consistently across explorer and non-explorer ui