[Feature]: default 404 page should return 404 status code

[vegerot]

What problem does this feature solve?

Make 404 page behave as expected. If the text of the page literally says 404 it's expected that the HTTP status code should be 404.

I ran into this because I was automating some tasks, and I expected that hitting this 404 page would return HTTP 404 but when my test failed it took me a few minutes to realize that the 404 page does not return 404.

What does the proposed API look like?

When SSRing, if we are going to show the 404 page, we should also set the HTTP status code to 404.

[zllkjc]

I argee, and will deal with this problem !

[yimingjfe]

I handled this issue, when rendering the default notfound page, it will return a 404 status code.

Because this behavior is a break change, it will work in Modern.js 3.0.

Currently, you can add a routes/$.data.ts file, and when rendering the $.tsx route component, return a 404 status code:

export const loader = () => {
  return new Response('404', { status: 404 });
};