update deps + loosen some requirements (#26)

* update deps + loosen some requirements

rules:
- for crates that are below v1.0 -> specify the precise version
- If the code uses a feature that was added for example in X 0.3.17,
  then you should specify 0.3.17, which actually means "0.3.y where y >=
  17"
- for crates the are above or equal v1.0 -> specify only major version
  if the crate's API is minimal and won't change between minor versions
    OR specify major&minor versions otherwise

tested with https://github.com/taiki-e/cargo-minimal-versions

* fix warnings

Author: melekes

.github/workflows/cargo.yml

@@ -10,41 +10,76 @@ env:
   CARGO_TERM_COLOR: always
 
 jobs:
-  build:
-    name: Build and test
+  check_and_test:
+    name: Check and test
     strategy:
       matrix:
         os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
+        toolchain:
+          - 1.56.1 # min supported version (https://github.com/webrtc-rs/webrtc/#toolchain)
+          - stable
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v2
-      - name: Build
-        run: cargo build --verbose
-      - name: Run tests
-        run: cargo test --verbose
+      - uses: actions/checkout@v3
+      - name: Cache cargo registry
+        uses: actions/cache@v3
+        with:
+          path: ~/.cargo/registry
+          key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }}
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: ${{ matrix.toolchain }}
+          profile: minimal
+          override: true
+      - uses: actions-rs/cargo@v1
+        with:
+          command: check
+      - uses: actions-rs/cargo@v1
+        with:
+          command: test
 
   rustfmt_and_clippy:
-    name: Check rustfmt style && run clippy
+    name: Check rustfmt style and run clippy
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.55.0
+          toolchain: stable
           profile: minimal
           components: clippy, rustfmt
           override: true
       - name: Cache cargo registry
-        uses: actions/cache@v1
+        uses: actions/cache@v3
         with:
           path: ~/.cargo/registry
           key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }}
       - name: Run clippy
         uses: actions-rs/cargo@v1
         with:
           command: clippy
+          args: -- -D warnings
       - name: Check formating
         uses: actions-rs/cargo@v1
         with:
           command: fmt
           args: --all -- --check
+
+  minimal_versions:
+    name: Compile and test with minimal versions
+    strategy:
+      matrix:
+        os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v3
+      - name: Install latest nightly
+        uses: actions-rs/toolchain@v1
+        with:
+            toolchain: nightly
+            override: true
+      - uses: taiki-e/install-action@cargo-hack
+      - uses: taiki-e/install-action@cargo-minimal-versions
+      - run: cargo minimal-versions check --workspace --all-features --ignore-private -v
+      - run: cargo minimal-versions build --workspace --all-features --ignore-private -v
+      - run: cargo minimal-versions test --workspace --all-features -v

Cargo.toml

@@ -16,16 +16,16 @@ default = [ "reuse_port" ]
 reuse_port = []
 
 [dependencies]
-util = { package = "webrtc-util", version = "0.5.3", default-features = false, features = ["ifaces"] }
-tokio = { version = "1.15.0", features = ["full"] }
-socket2 = { version = "0.4.2", features = ["all"] }
-log = "0.4.14"
-thiserror = "1.0.30"
+util = { package = "webrtc-util", version = "0.5.4", default-features = false, features = ["ifaces"] }
+tokio = { version = "1.19", features = ["full"] }
+socket2 = { version = "0.4.4", features = ["all"] }
+log = "0.4"
+thiserror = "1.0"
 
 [dev-dependencies]
 env_logger = "0.9.0"
 chrono = "0.4.19"
-clap = "2.34.0"
+clap = "3.2.6"
 
 [[example]]
 name = "mdns_query"

src/message/header.rs

@@ -1,7 +1,7 @@
 use super::*;
 
 // Header is a representation of a DNS message header.
-#[derive(Default, Debug, Copy, Clone, PartialEq)]
+#[derive(Default, Debug, Copy, Clone, PartialEq, Eq)]
 pub struct Header {
     pub id: u16,
     pub response: bool,
@@ -54,7 +54,7 @@ impl Header {
     }
 }
 
-#[derive(Copy, Clone, PartialOrd, PartialEq)]
+#[derive(Copy, Clone, PartialOrd, PartialEq, Eq)]
 pub enum Section {
     NotStarted = 0,
     Header = 1,

src/message/message_test.rs

@@ -44,7 +44,7 @@ fn small_test_msg() -> Result<Message> {
         }],
         additionals: vec![Resource {
             header: ResourceHeader {
-                name: name,
+                name,
                 typ: DnsType::A,
                 class: DNSCLASS_INET,
                 ..Default::default()
@@ -201,7 +201,7 @@ fn large_test_msg() -> Result<Message> {
             },
             Resource {
                 header: ResourceHeader {
-                    name: name,
+                    name,
                     typ: DnsType::Txt,
                     class: DNSCLASS_INET,
                     ..Default::default()

src/message/mod.rs

@@ -22,7 +22,7 @@ use std::fmt;
 // Message formats
 
 // A Type is a type of DNS request and response.
-#[derive(Copy, Clone, Debug, PartialEq)]
+#[derive(Copy, Clone, Debug, PartialEq, Eq)]
 pub enum DnsType {
     // ResourceHeader.Type and question.Type
     A = 1,
@@ -167,7 +167,7 @@ impl DnsClass {
 pub type OpCode = u16;
 
 // An RCode is a DNS response status code.
-#[derive(Copy, Clone, Debug, PartialEq)]
+#[derive(Copy, Clone, Debug, PartialEq, Eq)]
 pub enum RCode {
     // Message.Rcode
     Success = 0,

src/message/name.rs

@@ -7,7 +7,7 @@ const NAME_LEN: usize = 255;
 
 // A Name is a non-encoded domain name. It is used instead of strings to avoid
 // allocations.
-#[derive(Default, PartialEq, Debug, Clone)]
+#[derive(Default, PartialEq, Eq, Debug, Clone)]
 pub struct Name {
     pub data: String,
 }

src/message/question.rs

@@ -6,7 +6,7 @@ use std::collections::HashMap;
 use std::fmt;
 
 // A question is a DNS query.
-#[derive(Default, Debug, PartialEq, Clone)]
+#[derive(Default, Debug, PartialEq, Eq, Clone)]
 pub struct Question {
     pub name: Name,
     pub typ: DnsType,

src/message/resource/a.rs

@@ -2,7 +2,7 @@ use super::*;
 use crate::message::packer::*;
 
 // An AResource is an A Resource record.
-#[derive(Default, Debug, Clone, PartialEq)]
+#[derive(Default, Debug, Clone, PartialEq, Eq)]
 pub struct AResource {
     pub a: [u8; 4],
 }

src/message/resource/aaaa.rs

@@ -2,7 +2,7 @@ use super::*;
 use crate::message::packer::*;
 
 // An AAAAResource is an aaaa Resource record.
-#[derive(Default, Debug, Clone, PartialEq)]
+#[derive(Default, Debug, Clone, PartialEq, Eq)]
 pub struct AaaaResource {
     pub aaaa: [u8; 16],
 }

src/message/resource/cname.rs

@@ -2,7 +2,7 @@ use super::*;
 use crate::message::name::*;
 
 // A cnameresource is a cname Resource record.
-#[derive(Default, Debug, Clone, PartialEq)]
+#[derive(Default, Debug, Clone, PartialEq, Eq)]
 pub struct CnameResource {
     pub cname: Name,
 }