SwaggerChecker falls back to a local load #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It looks like Travis is having some setup issues with the older versions of Ruby |
This was referenced Nov 20, 2017
|
Can you re-run these test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87
I wanted to be able to load the Swagger file without it necessarily being reachable from Rails integration testing, so I added this fallback. A better approach might be to have a pluggable loader that allows the user to specify the loading mechanism. I would love to be able to use Apivore in some command-line scripts that aren't related to testing (ie, generating documentation), so removing an automatic dependence on the Rails environment is a good start.