signer param in prepareSendTransaction is misleading
#1458
Unanswered
ElasticBottle
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
If we look at
@wagmi/core, theprepareSendTransactiontakes in a signer which allows for overriding the underlying signer. That is perfect for my use case, but thesignerbeing passed in is only ever being used to estimate the gas.Later, in
sendTransaction, there is not longer asigneroption and we fall back to callingfetchSigner.Is this intended? Feels like an incomplete follow-through with the signer override. What was the original reason for allowing
signerinprepareSendTransaction?Happy to pick this up and contribute the
signeroverrideBeta Was this translation helpful? Give feedback.
All reactions