Replies: 1 comment 1 reply
-
|
hey @mariopil, I'm currently working on something similar, and noticed that this discussion didn't actually proceed since 2023. Did you figure out the wagmi implementation on your end? We've been thinking about handling it by hijacking each request to the RPC through passing |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello, I'm currently developing support for EIP712 signers in ZkSync in
viem(PR opened here ) and have recently started testing the implementation withwagmi. From what I have noticed there are small changes required inwagmito be able to properly send EIP712 transactions which contain few additional fields. Hooks likeuseSendTransactionoruseContractWritehave all transaction fields specified explicitly, therefore all the EIP712 fields would need to be added there too (and also in all methods that are called from there internally).Currently the transaction structure in
viemis flat, as discussed here so that would mean adding 5 new fields everywhere:The other approach could be to put all those fields into separate structure, like it was initially proposed, and then add only
customDataparam inwagmihooks:That would require some changes in the
viemPR too.Before I start implementing changes I would like to have your opinion about it. What do you think would be the best approach here?
Beta Was this translation helpful? Give feedback.
All reactions