You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, currently connectors imports third party SDK using dynamic import which is good, but Angular/ESbuild still adds all of it to lazy chunks , it cannot tree shake such dynamic imports correctly, for example our app imports connectors like this:
but bundle still includes lazy chunk for metamask-sdk as shown below:
also it seems new connectors are added regularly, which will add unused lazy chunk in Angular/ESbuild based project.
Supporting connectors import like this could solve this:
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Hi, currently connectors imports third party SDK using dynamic import which is good, but Angular/ESbuild still adds all of it to lazy chunks , it cannot tree shake such dynamic imports correctly, for example our app imports connectors like this:
but bundle still includes lazy chunk for metamask-sdk as shown below:
also it seems new connectors are added regularly, which will add unused lazy chunk in Angular/ESbuild based project.
Supporting connectors import like this could solve this:
Beta Was this translation helpful? Give feedback.
All reactions