Skip to content

Commit 05cf770

Browse files
authored
(Truly) fix possible crash in recommended content. (#4948)
1 parent 73bdc8a commit 05cf770

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

app/src/main/java/org/wikipedia/search/RecentSearchesFragment.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import android.view.ViewGroup
77
import android.widget.TextView
88
import androidx.core.view.isInvisible
99
import androidx.fragment.app.Fragment
10+
import androidx.fragment.app.commit
11+
import androidx.fragment.app.replace
1012
import androidx.lifecycle.lifecycleScope
1113
import androidx.recyclerview.widget.ItemTouchHelper
1214
import androidx.recyclerview.widget.LinearLayoutManager
@@ -106,10 +108,7 @@ class RecentSearchesFragment : Fragment() {
106108
val isGeneralized = RecommendedContentAnalyticsHelper.abcTest.group == ABTest.GROUP_2
107109
val langeCode = callback?.getLangCode() ?: WikipediaApp.instance.appOrSystemLanguageCode
108110
recommendedContentFragment = RecommendedContentFragment.newInstance(wikiSite = WikiSite.forLanguageCode(langeCode), isGeneralized)
109-
childFragmentManager.beginTransaction()
110-
.add(R.id.fragmentOverlayContainer, recommendedContentFragment!!, null)
111-
.addToBackStack(null)
112-
.commit()
111+
childFragmentManager.commit { replace(R.id.fragmentOverlayContainer, recommendedContentFragment!!) }
113112
}
114113

115114
private fun updateSearchEmptyView(searchesEmpty: Boolean) {

0 commit comments

Comments
 (0)